Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JOSS paper based on reviewer two #11

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Update JOSS paper based on reviewer two #11

merged 10 commits into from
Apr 16, 2024

Conversation

Timozen
Copy link
Member

@Timozen Timozen commented Apr 16, 2024

Update the JOSS paper based on the review of @draabe.

  • Updated the summary to be more transparent about why blinking is important (add relevant medical papers)
  • Improve the statement of need to include current medical (non-image approaches) for blinking measurement
  • minor fixes of grammar and spelling
  • make the distinction between programming API and GUI more clear
  • give an example of how existing medical features could extend the API in the future
  • update reference of Lugares et al. not to use the arxiv version

@Timozen
Update summary
41dd814 
- describe non-facial norm more
- add more references for non-experts reader for possible follow up
@Timozen
Update summary
0c71627 
- make usage of computer vision a bit clearer
@Timozen
Update summary
62329e1 
- smooth the transition between paragraphs
- include references for the reader
@Timozen
Update statement of need
80dbe33 
- include more existing approaches
- one for highspeed (but only every 5ms)
- two medical ones
- create new subsection for statement of need as some kind of overview
@Timozen
add missing high
641d247
@Timozen
split rather long sentence
2f136dd
@Timozen
Fix section header
c7b50b2 
-> medical -> medically
@Timozen
Make api and gui distinction more clear
47a8501 
- explain what api extendablilty means
- make api usage more clear
- make gui usage more clear
@Timozen
Fix some citations styles
73847d7
@Timozen
Update Lugares et al. paper
d5a2b5b 
- replace arxiv with cvpr workshop paper
@Timozen Timozen merged commit f29fd58 into main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Timozen