-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use go-cmp instead of reflect.DeepEqual #99
base: develop
Are you sure you want to change the base?
Conversation
@mekegi: This looks good to me, except can you please add a flag |
I see it has been a year since this PR was created. I would love to use |
+1 Now gopls checks
|
If OP or someone else can update this PR to resolve branch conflicts, I will approve it. |
#98
https://github.com/google/go-cmp/ is more usefull then reflect.DeepEqual
I changed reflect.DeepEqual to cmp.Equal
and add to t.Errorf cmp.Diff for more detailed view of diff between got and want
for exmaple how it looks like