Fix image filetype recognition #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filetype method does not work for all kinds of images.
data.unpack('n')[0] == 0xFFD8 passes but then image does not
have JFIF/Exif info in @DaTa so filetype is nil resulting a crash beacause
width and height cannot be set (image is not processed at all).
The solution is to use mimemagick for image type recognition.
Added republic_ps.jpg image that was generated by latest Photoshop CC with default settings
Added test for image import process
@dodo121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filetype method does not work for all kinds of images.
data.unpack('n')[0] == 0xFFD8passes but then image does nothave JFIF/Exif info in
@dataso filetype is nil resulting a crash becausewidth and height cannot be set (image is not processed at all).
The solution is to use mimemagick for image type recognition.
Added republic_ps.jpg image that was generated by latest Photoshop CC with default settings
Added test for image import process
@dodo121