-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented perform_command_mode_switch override in Ros2ControlSystem #846
base: master
Are you sure you want to change the base?
implemented perform_command_mode_switch override in Ros2ControlSystem #846
Conversation
I'm not sure if discovering which command interfaces are claimed inside |
I would prefer that you test and eventually solve the problem in this PR, rather than committing something which is unfinished or buggy. |
That's fair, though at the moment I'm not sure the issue is fixable without alterations to |
ea27318
to
4b2aa16
Compare
Description
Reusing the solution from here for Gazebo to allow for multiple command interfaces. Implements the
perform_command_mode_switch
method override to set joint control methods when controllers are activated/deactivated. Can't work out how to detect if a command interface is claimed insideRos2ControlSystem::init()
so you either have to runswitch_controllers
once to call the function or start with a position controller.Related Issues
This pull request references the discussion #845 I started earlier.
Affected Packages
Tasks
Ros2ControlSystem::init()
so it's all set up properly at the beginning without having to runswitch_controller
.Additional context
Credit to @ksotebeer for the original PR for
gazebo_ros2_control
.