Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate v1 and v2alpha1 SubNamespace API #128

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented May 15, 2024

The v2alpha1 version of the SubNamespace API has been available for a while, and I think it's time to consider deprecating the v1 version. The newer version has a much better observed state UX with conditions. We should probably make v2 (or v2beta1) available - to not "scare" our users from migrating (to an alpha version).

Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think v1 should be deplicate after releasing v2 or v2beta1.
If v1 is deplicate, users will not be able to decide which version to use.

@erikgb
Copy link
Contributor Author

erikgb commented May 20, 2024

I think v1 should be deplicate after releasing v2 or v2beta1.

Agree! Any more we want to adjust before v2 is finalized? I don't see anything missing from SubNamespace v2 API.

@zoetrope
Copy link
Member

@erikgb
I don't have anything else to add either. Everything looks good to me.

@erikgb
Copy link
Contributor Author

erikgb commented May 20, 2024

@erikgb I don't have anything else to add either. Everything looks good to me.

Should we just skip a beta-version of the API and go directly for v2? WDYT?

@zoetrope
Copy link
Member

Should we just skip a beta-version of the API and go directly for v2? WDYT?

I think it's fine to skip beta and go directly to v2.

@erikgb
Copy link
Contributor Author

erikgb commented May 24, 2024

Should we just skip a beta-version of the API and go directly for v2? WDYT?

I think it's fine to skip beta and go directly to v2.

Thanks, I will do the work required. Marking this PR as a draft for now.

@erikgb erikgb marked this pull request as draft May 24, 2024 10:03
@erikgb erikgb mentioned this pull request Jun 7, 2024
@erikgb erikgb force-pushed the deprecate-v1 branch 2 times, most recently from 9cfc2db to 915ff1d Compare June 10, 2024 17:08
@erikgb erikgb marked this pull request as ready for review June 10, 2024 17:08
@erikgb
Copy link
Contributor Author

erikgb commented Jun 10, 2024

@zoetrope After making the v2 API served, ref. #132, I think this PR is ready for review and eventual merge. Marking the types as deprecated also will help us identify code we need to migrate.

@erikgb erikgb changed the title chore: deprecate v1 SubNamespace API chore: deprecate v1 and v2alpha1 SubNamespace API Jun 10, 2024
@erikgb
Copy link
Contributor Author

erikgb commented Jul 4, 2024

@zoetrope A gentle ping for a review of this PR. 🙏 I also have other open unreviewed PRs. 🙏 We prefer if a new release is cut as soon as possible. 🤠

@zoetrope
Copy link
Member

zoetrope commented Jul 5, 2024

@erikgb
Sorry for the very late reply. I am planning to make a release.
Can I release v1.4.0 after this PR is merged?

@erikgb
Copy link
Contributor Author

erikgb commented Jul 5, 2024

@erikgb Sorry for the very late reply. I am planning to make a release. Can I release v1.4.0 after this PR is merged?

@zoetrope Great! Would it be possible to include all open PRs before we cut the release? In particular, I would like to get #142 in somehow.

@zoetrope zoetrope merged commit 4b22f41 into cybozu-go:main Jul 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants