Use image hosted on ghcr.io #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-kuro
force-pushed
the
d-kuro/ghcrio-image
branch
7 times, most recently
from
c7bc4bc
to
6c312b9
Compare
d-kuro
force-pushed
the
d-kuro/ghcrio-image
branch
6 times, most recently
from
d66d828
to
94e671f
Compare
d-kuro
commented
Jul 26, 2023
masa213f
requested changes
Jul 27, 2023
Comment on lines
39
to
43
| if [ "${#array[@]}" -eq 0 ]; then | ||
| json_output="[]" | ||
| else | ||
| json_output=$(printf '%s\n' "${array[@]}" | jq -R . | jq -s . | jq -c .) | ||
| fi |
There was a problem hiding this comment.
We seems to write it more easily.
echo "${array[@]}" | jq -Rc 'split(" ")'
$ array=()
$ array+=( "hoge" )
$ array+=( "piyo" )
$ array+=( "fuga" )
$ echo "${array[@]}"
hoge piyo fuga
$ echo "${array[@]}" | jq -Rc 'split(" ")'
["hoge","piyo","fuga"]$ array2=()
$ echo "${array2[@]}"
$ echo "${array2[@]}" | jq -Rc 'split(" ")'
[]There was a problem hiding this comment.
Thanks 🙏 Simplicity now!
41ae011
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
masa213f
force-pushed
the
d-kuro/ghcrio-image
branch
from
dfb21f5
to
2837164
Compare
|
I rebased this PR because it conflicted with #548. |
masa213f
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use image hosted on
ghcr.io.We also use a local mysql image to run E2E tests after building the MySQL image.
This allows more detailed testing of the built mysql image.