Update proposal to allow individual stopping of clustering and reconciliation #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masa213f
requested changes
Sep 27, 2023
docs/designdoc/clustering_stop.md
Outdated
Comment on lines
114
to
117
| - type: ReconciliationStopped | ||
| status: "True" | ||
| lastTransitionTime: 2018-01-01T00:00:00Z |
There was a problem hiding this comment.
When a MySQL cluster is normal, I want all ".status.conditions" to be "true".
Could you rename the type of the condition to reverse the boolean value?
Also, please rename the following names.
- Header of
kubectl get mysqlcluster Annotation keyMetrics name
…iliation Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
d-kuro
force-pushed
the
d-kuro/update-docs
branch
from
d65690e
to
5fb913a
Compare
zoetrope
reviewed
Oct 17, 2023
docs/designdoc/clustering_stop.md
Outdated
|
|
||
| ```console | ||
| $ kubectl get mysqlcluster | ||
| NAME AVAILABLE HEALTHY STOPPED PRIMARY SYNCED REPLICAS ERRANT REPLICAS LAST BACKUP | ||
| test Unknown Unknown True 0 2 <no value> | ||
| NAME AVAILABLE HEALTHY PRIMARY SYNCED REPLICAS ERRANT REPLICAS CLUSTERING STOPPED RECONCILE STOPPED LAST BACKUP |
There was a problem hiding this comment.
Is this correct?
The following section uses "CLUSTERING ACTIVE" and "RECONCILE ACTIVE".
There was a problem hiding this comment.
Thanks 🙏
I fixed: 06e8204
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #564