Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add reroutes for routes linked from outside blogs to real URLs #5611

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

jennifer-shehane
Copy link
Member

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit d22a9b3
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65aaa26665c51b000890e5e8
😎 Deploy Preview https://deploy-preview-5611--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny questions/comments

@@ -505,6 +505,276 @@
status = 301
force = true

[[redirects]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a repeat of the one just above it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed d22a9b3 (#5611)

status = 301
force = true

[[redirects]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine to load the IDE section since it's related. But there is a /guides/tooling/ide-integration/#Intelligent-Code-Completion section if we wanted to deeplink

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah I didn't want to do any deep linking because that's more likely to get out of date.

status = 301
force = true

[[redirects]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a quick way to test this, but would the previous entry suffice without another including the trailing slash?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Figured this covers it anyhow

Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jennifer-shehane jennifer-shehane merged commit af68ad7 into main Jan 19, 2024
10 checks passed
@jennifer-shehane jennifer-shehane deleted the reroute-404-routes branch January 19, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants