-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies (install Docusaurus 3) #5601
Conversation
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7825b70
to
f32243f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with all this. Nice job working through the remark stuff 💪
Two q's just for my edification:
- Why does the prettier need to work sync?
- I didn't quite understand the header hashes caveat you mentioned. Did something not translate in v3?
The
Before, when an icon was in a header, the Icon name was made part of the ID. We went around it with adding stuff at the end of header lines. ### Yields [<IconHelp>](https://example-docs.org/yields) {#Yields}
^^^^^^^ Problem is: on some pages the "acorn" parser did not like it one bit. I removed it where it was problematic and the hash have not changed. The one above for instance is still "Yields" |
Caveat: some customized header hashes cannot be parsed in DS3. See Yields has disapeared here. The end result seems the same. so I am not worried.