-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add reroutes for routes linked from outside blogs to real URLs #5611
Conversation
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few tiny questions/comments
@@ -505,6 +505,276 @@ | |||
status = 301 | |||
force = true | |||
|
|||
[[redirects]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a repeat of the one just above it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed d22a9b3
(#5611)
status = 301 | ||
force = true | ||
|
||
[[redirects]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine to load the IDE section since it's related. But there is a /guides/tooling/ide-integration/#Intelligent-Code-Completion
section if we wanted to deeplink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah I didn't want to do any deep linking because that's more likely to get out of date.
status = 301 | ||
force = true | ||
|
||
[[redirects]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's a quick way to test this, but would the previous entry suffice without another including the trailing slash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. Figured this covers it anyhow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Based on https://docs.google.com/spreadsheets/d/17u7EsUQNPjHntfqAFPLzEjiIyDMIwU5SVMYEADjLcUQ/edit#gid=0