Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify node version #23

Closed
prescottprue opened this issue Nov 15, 2019 · 5 comments · Fixed by #24
Closed

Specify node version #23

prescottprue opened this issue Nov 15, 2019 · 5 comments · Fixed by #24
Labels

Comments

@prescottprue
Copy link
Contributor

prescottprue commented Nov 15, 2019

Even when using the node setup action before this action, node 12.13 is still being used:

    - name: Setup Node
      uses: actions/setup-node@v1
      with:
        node-version: 10

    - name: Cypress Run
      uses: cypress-io/github-action@v1
      with:
        record: true
      env:
        # pass the Dashboard record key as an environment variable
        CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_KEY }}

The error that includes node version:

image

Is there a way to set node version that I am missing? If not, it would awesome if this was an input

@bahmutov
Copy link
Contributor

Hi @prescottprue thanks for trying it out. I have configured and example project here https://github.com/bahmutov/cypress-gh-action-example that shows that the original Node version is respected. I think the problem here is that the cache only looks at system platform + package file hash, and does not take into account Node version which causes native extension from Node 10 for example be installed when running on Node 12.

I think the best scenario would be to allow user to specify hash key as a parameter, let me see if this could work.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prescottprue
Copy link
Contributor Author

This worked out great, awesome work

@h2oearth
Copy link

h2oearth commented Jun 2, 2022

This worked for me #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants