feat: upgrade to use Node v18, remove v12 #637

jaffrepaul · 2022-11-21T21:58:02Z

BREAKING CHANGE:

Add node v18 support & remove deprecated v12.

add node v18, remove deprecated v12 in example-node-versions.yml test matrix
add node v18, remove v12 in main.yml
bump ncc pkg to fix ERR_OSSL_EVP_UNSUPPORTED errors intruduced in node > node v16 (fix: use sha instead of deprecated md5 for hash algorithm vercel/ncc#868)
bump @types/node to latest
bump actions/setup-node, actions/checkout to v3 to prevent < v16 deprecation warnings
rename tests for clarity

CLAassistant · 2022-11-21T21:58:07Z

All committers have signed the CLA.

MikeMcC399 · 2022-11-28T21:22:33Z

@jaffrepaul

Thanks for addressing the issue Add support for Node.js 18 (Active LTS version) #623 I reported!

jennifer-shehane · 2022-11-29T19:40:17Z

@jaffrepaul Are these tests actually running on Node 18? I see the 14, 16, and 18 tests showing v16 in the Cypress test output as the Node version for testing.

MikeMcC399 · 2022-11-30T09:21:51Z

Perhaps this would be a good time to update the following?

uses: actions/setup-node@v2 to v3
uses: actions/checkout@v2 to v3

The older versions produce deprecation warnings regarding Node.js 12.

jaffrepaul · 2022-11-30T22:31:09Z

Perhaps this would be a good time to update the following?

uses: actions/setup-node@v2 to v3 uses: actions/checkout@v2 to v3

The older versions produce deprecation warnings regarding Node.js 12.

@MikeMcC399. I'm hoping to update a number of outdated deps throughout this action soon, including these bumps. That will be treated as a separate effort but I don't mind including these here since it's very related 👍

jaffrepaul · 2022-11-30T22:59:12Z

@jennifer-shehane I believe that output is just noting the node version of the GH hosted runner (2.299.1) that runs the workflows. The tooling there can change over time. We do specify a v16 runtime in the meta data of our action as required. This is also subject to change once 16 reaches EOL.

As you mentioned the workflow summary shows the correct node version in the setup & echo in each step. Tho it is curious that the output follows those.

MikeMcC399 · 2022-12-02T17:44:51Z

@jaffrepaul

There is a tag
https://github.com/cypress-io/github-action/releases/tag/v5.0.0
but no tag
https://github.com/cypress-io/github-action/releases/tag/v5 (as recommended in https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions)
nor a branch
https://github.com/cypress-io/github-action/tree/v5

so specifying cypress-io/github-action@v5 doesn't work.
"Unable to resolve action cypress-io/github-action@v5, unable to find version v5"

Is it intentional not to have released a generic v5 version at the moment?

MikeMcC399 · 2022-12-02T18:03:54Z

@jennifer-shehane / @jaffrepaul

There seems to be a caching issue with the action. I also see
/opt/hostedtoolcache/node/18.12.1/x64/bin/npx cypress verify
then

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:        11.2.0                                                                         │
  │ Browser:        Chrome 107 (headless)                                                          │
  │ Node Version:   v16.13.0 (/home/runner/runners/2.299.1/externals/node16/bin/node)              │

with the wrong Node.js version (v16.13.0) being shown by Cypress instead of the previously selected and expected v18.12.1.

This is using the sequence:

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3
      - name: Setup Node.js 18 environment
        uses: actions/setup-node@v3
        with:
          node-version: 'lts/hydrogen'
      - name: Cypress run
        uses: cypress-io/github-action@v5.0.0

For comparison, if Cypress is called directly then the expected Node,js version 18 is shown in the Cypress log:

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress:        11.2.0                                                                         │
│ Browser:        Chrome 107 (headless)                                                          │
│ Node Version:   v18.12.1 (/opt/hostedtoolcache/node/18.12.1/x64/bin/node)                      │

executed through:

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3
      - name: Setup Node.js 18 environment
        uses: actions/setup-node@v3
        with:
          node-version: 'lts/hydrogen'
      - name: npm install
        run: npm ci
      - name: Cypress run
        run: npx cypress run -s cypress/e2e/test.cy.js --browser chrome

I guess if this is going to be looked at it should be in a separate new open issue.

jaffrepaul · 2022-12-02T19:30:45Z

@jaffrepaul

There is a tag https://github.com/cypress-io/github-action/releases/tag/v5.0.0 but no tag https://github.com/cypress-io/github-action/releases/tag/v5 (as recommended in https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions) nor a branch https://github.com/cypress-io/github-action/tree/v5

so specifying cypress-io/github-action@v5 doesn't work. "Unable to resolve action cypress-io/github-action@v5, unable to find version v5"

Is it intentional not to have released a generic v5 version at the moment?

This step is normally handled in CI. There was an issue with the release trigger during merge and it appears some steps didn't take. Will get a look.

jaffrepaul · 2022-12-02T19:45:16Z

@MikeMcC399 The v5 tag issue is settled. You can now pull in github-action@v5. Digging into the caching issue.

MikeMcC399 · 2022-12-02T20:15:12Z

@jaffrepaul

The v5 tag issue is settled. You can now pull in github-action@v5.

Thank you very much. I confirm that this now works!

Digging into the caching issue.

That's good! I set up two tests, one with and one without using the action on https://github.com/MikeMcC399/cypress-test-tiny. They use latest versions of everything: Ubuntu 22.04, Node.js 18 (LTS), Cypress 11.2.0 and github-action@v5

Let me know if you prefer to have a separate issue to track this.

Edit: See issue #642 for logs

jaffrepaul · 2022-12-02T20:18:22Z

@MikeMcC399 separate issue please 👍

MikeMcC399 · 2022-12-02T20:53:56Z

@jaffrepaul

The Node,js version selection problem is described in the new issue Runner externals Node.js version v16.13.0 always used in GHA runs #642

I hope this is helpful!

MikeMcC399 · 2022-12-03T17:23:32Z

I don't think this is a cache issue anymore. See #642 (comment).

MikeMcC399 · 2022-12-05T18:46:33Z

@jennifer-shehane

Are these tests actually running on Node 18? I see the 14, 16, and 18 tests showing v16 in the Cypress test output as the Node version for testing.

This is a old known issue. See Hard coded Node.js version #489

MikeMcC399 · 2022-12-06T15:55:47Z

@jaffrepaul

This step is normally handled in CI. There was an issue with the release trigger during merge and it appears some steps didn't take. Will get a look.

It looks like the problem was that the "BREAKING CHANGE:" text wasn't in the body of the commit c5724ed. I can only see "feat: upgrade to use Node v18, remove v12" in it.

jaffrepaul · 2022-12-07T17:45:18Z

@MikeMcC399 Indeed, I noticed that after the fact. We're working on getting a number of things updated on our side and appreciate the extra eyes!

jaffrepaul force-pushed the update-node-version branch 4 times, most recently from 6275b26 to cbabc7e Compare November 28, 2022 21:18

MikeMcC399 mentioned this pull request Nov 28, 2022

Add support for Node.js 18 (Active LTS version) #623

Closed

jaffrepaul changed the title ~~add node 18 to matrix~~ feat: add node 18 to matrix Nov 28, 2022

jaffrepaul changed the title ~~feat: add node 18 to matrix~~ feat: upgrade to use Node v18, remove v12 Nov 28, 2022

jaffrepaul force-pushed the update-node-version branch from cbabc7e to 680cec5 Compare November 28, 2022 21:41

jaffrepaul requested a review from a team November 28, 2022 21:58

jaffrepaul force-pushed the update-node-version branch from 97f587d to 5cf99fc Compare November 30, 2022 22:21

add node v18 to test matrix, remove deprecated v12

dcf1e6c

jaffrepaul force-pushed the update-node-version branch from 5cf99fc to dcf1e6c Compare November 30, 2022 22:27

jaffrepaul requested a review from jennifer-shehane December 1, 2022 18:47

jennifer-shehane approved these changes Dec 1, 2022

View reviewed changes

jaffrepaul merged commit c5724ed into master Dec 1, 2022

jaffrepaul added the released label Dec 2, 2022

jaffrepaul mentioned this pull request Dec 7, 2022

chore(deps): update dependency @types/node to v18.11.11 #645

Closed

1 task

jaffrepaul deleted the update-node-version branch January 5, 2023 23:05

ntsummers1 mentioned this pull request Jul 27, 2023

MLR E2E Updates Enterprise-CMCS/macpro-mdct-mcr#11389

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to use Node v18, remove v12 #637

feat: upgrade to use Node v18, remove v12 #637

jaffrepaul commented Nov 21, 2022 •

edited

Loading

CLAassistant commented Nov 21, 2022 •

edited

Loading

MikeMcC399 commented Nov 28, 2022

jennifer-shehane commented Nov 29, 2022

MikeMcC399 commented Nov 30, 2022

jaffrepaul commented Nov 30, 2022

jaffrepaul commented Nov 30, 2022 •

edited

Loading

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

MikeMcC399 commented Dec 2, 2022

jaffrepaul commented Dec 2, 2022 •

edited

Loading

jaffrepaul commented Dec 2, 2022

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

jaffrepaul commented Dec 2, 2022

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

MikeMcC399 commented Dec 3, 2022 •

edited

Loading

MikeMcC399 commented Dec 5, 2022

MikeMcC399 commented Dec 6, 2022 •

edited

Loading

jaffrepaul commented Dec 7, 2022

feat: upgrade to use Node v18, remove v12 #637

feat: upgrade to use Node v18, remove v12 #637

Conversation

jaffrepaul commented Nov 21, 2022 • edited Loading

CLAassistant commented Nov 21, 2022 • edited Loading

MikeMcC399 commented Nov 28, 2022

jennifer-shehane commented Nov 29, 2022

MikeMcC399 commented Nov 30, 2022

jaffrepaul commented Nov 30, 2022

jaffrepaul commented Nov 30, 2022 • edited Loading

MikeMcC399 commented Dec 2, 2022 • edited Loading

MikeMcC399 commented Dec 2, 2022

jaffrepaul commented Dec 2, 2022 • edited Loading

jaffrepaul commented Dec 2, 2022

MikeMcC399 commented Dec 2, 2022 • edited Loading

jaffrepaul commented Dec 2, 2022

MikeMcC399 commented Dec 2, 2022 • edited Loading

MikeMcC399 commented Dec 3, 2022 • edited Loading

MikeMcC399 commented Dec 5, 2022

MikeMcC399 commented Dec 6, 2022 • edited Loading

jaffrepaul commented Dec 7, 2022

jaffrepaul commented Nov 21, 2022 •

edited

Loading

CLAassistant commented Nov 21, 2022 •

edited

Loading

jaffrepaul commented Nov 30, 2022 •

edited

Loading

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

jaffrepaul commented Dec 2, 2022 •

edited

Loading

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

MikeMcC399 commented Dec 2, 2022 •

edited

Loading

MikeMcC399 commented Dec 3, 2022 •

edited

Loading

MikeMcC399 commented Dec 6, 2022 •

edited

Loading