-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker examples in README to Node.js 18 #681
Update Docker examples in README to Node.js 18 #681
Conversation
2b056c5
to
fc43671
Compare
1ecc405
to
485354a
Compare
485354a
to
80fabca
Compare
80fabca
to
3853ff0
Compare
@jaffrepaul / @jennifer-shehane Perhaps one of you could also review this PR from last month? |
@MikeMcC399 this is high on my list of the older PRs to get a look at. I should have time by the end of the week 🥂 |
Thank you. It's non-critical. I just wanted to make sure it hadn't got forgotten. I understand though that there's a lot going on at the moment. |
This conforms to the GitHub documentation Lines 90 to 92 in 821aeac
which selects the action to run under
|
Cool, just making sure that was all aligning as expected. |
🎉 This PR is included in version 5.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR resolves the documentation issue #680 "Example uses Docker image with end-of-life Node.js 12".
In the documentation examples
the Cypress Docker image
cypress/browsers:node18.12.0-chrome106-ff106 is substituted for the
cypress/browsers:node12.13.0-chrome78-ff70 Docker image,
since Node.js 12 already passed End-of-Life last year on 2022-04-30 according to the End-of-Life Releases list.
Verification
Create a new workflow
example-docker.yml
in the.github/workflows
directory of a local copy of a fork of this repository as below:Push the example to the repository and ensure that the action log shows that it ran successfully.
Similarly for the Firefox example.