Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker examples in README to Node.js 18 #681

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 21, 2022

This PR resolves the documentation issue #680 "Example uses Docker image with end-of-life Node.js 12".

In the documentation examples

the Cypress Docker image

since Node.js 12 already passed End-of-Life last year on 2022-04-30 according to the End-of-Life Releases list.

Verification

Create a new workflow example-docker.yml in the .github/workflows directory of a local copy of a fork of this repository as below:

name: E2E in custom container
on: [push]
jobs:
  cypress-run:
    runs-on: ubuntu-20.04
    # Cypress Docker image with Chrome v106
    # and Firefox v106 pre-installed
    container: cypress/browsers:node18.12.0-chrome106-ff106
    steps:
      - uses: actions/checkout@v3
      - uses: cypress-io/github-action@v5
        with:
          browser: chrome
          working-directory: examples/basic

Push the example to the repository and ensure that the action log shows that it ran successfully.

Similarly for the Firefox example.

@MikeMcC399 MikeMcC399 marked this pull request as draft December 23, 2022 18:44
@MikeMcC399 MikeMcC399 changed the title Update Docker example in README to Node.js 18 Update Docker examples in README to Node.js 18 Dec 23, 2022
@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 27, 2022 08:58
@MikeMcC399 MikeMcC399 force-pushed the update/docker-example branch 3 times, most recently from 1ecc405 to 485354a Compare January 13, 2023 19:49
@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul / @jennifer-shehane

Perhaps one of you could also review this PR from last month?

@jaffrepaul
Copy link
Contributor

@MikeMcC399 this is high on my list of the older PRs to get a look at. I should have time by the end of the week 🥂

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

this is high on my list of the older PRs to get a look at. I should have time by the end of the week

Thank you. It's non-critical. I just wanted to make sure it hadn't got forgotten. I understand though that there's a lot going on at the moment.

@jaffrepaul
Copy link
Contributor

I'm seeing this initialize correctly
Screen Shot 2023-01-27 at 5 51 38 PM

But the run output uses node 16
Screen Shot 2023-01-27 at 5 51 58 PM

@MikeMcC399
Copy link
Collaborator Author

@jaffrepaul

But the run output uses node 16

This conforms to the GitHub documentation runs for JavaScript actions and

github-action/action.yml

Lines 90 to 92 in 821aeac

runs:
using: 'node16'
main: 'dist/index.js'

which selects the action to run under node16.

@jaffrepaul jaffrepaul added the documentation Improvements or additions to documentation label Jan 30, 2023
@jaffrepaul
Copy link
Contributor

Cool, just making sure that was all aligning as expected.

@jaffrepaul jaffrepaul merged commit 84f5c61 into cypress-io:master Jan 30, 2023
@MikeMcC399 MikeMcC399 deleted the update/docker-example branch January 30, 2023 18:05
@github-actions
Copy link

🎉 This PR is included in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants