WIP: Refactor project into Swift Package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @cyrilzakka, I got most of it working. However, I'm having some problems with the transformation applied when the modal is open. It seems that when I try to change the modal position from outside, it won't detect the needed offset / opacity correctly. Do you have a moment to help me solve this? 😀 |
kevinrpb
changed the title
|
Will definitely take a look at this as soon as possible! Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a SPM package and set the ModalView part as a framework so that it can be imported from Xcode 11 as a dependency
Move the former project into another target as a demo
Let me know what you think and/or if I should change anything =D