Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs introduced by hot reloading of targets #108

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

hikhvar
Copy link
Contributor

@hikhvar hikhvar commented Mar 26, 2024

Improve speedup time by doing the intial DNS resolution also in parallel.

Fix edge cases if big files are created and truncated.

Refactor the ping collector such that it doesn't rely on global variables anymore. Add support for updating the target configs such that the label values can be updated per target. The set of labels names is not updated, as this will break the prometheus Collector interface.

Improve speedup time by doing the intial DNS resolution also in parallel.
@hikhvar hikhvar requested a review from czerwonk as a code owner March 26, 2024 19:45
@hikhvar hikhvar changed the title Fix edge cases if big files are created and truncated. Fix bugs introduced by hot reloading of targets Mar 26, 2024
Copy link
Owner

@czerwonk czerwonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czerwonk czerwonk merged commit f5f97ad into czerwonk:main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants