Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height optionContainer #27

Open
anarwade opened this issue Nov 24, 2016 · 3 comments
Open

Height optionContainer #27

anarwade opened this issue Nov 24, 2016 · 3 comments

Comments

@anarwade
Copy link

Hi,

At the moment, there is no way to adjust the height of the optionContainer. Could you please add another property so we can change it? On some mobile phones this height (const OPTION_CONTAINER_HEIGHT = 400;) is too large and the cancel button shows outside the screen.
Thank you

Greetings,

A. Narwade

@atennapel
Copy link

In my fork I simply added a way to style the optionContainer and cancelContainer: atennapel@d88050f

@yaakua
Copy link

yaakua commented Dec 2, 2016

I need this too ,TKS!

@peacechen
Copy link

peacechen commented Jan 27, 2017

I recommend removing the static OPTION_CONTAINER_HEIGHT and instead use flex. This would allow optionContainer to automatically stretch (or shrink) to its contents, limited by the device size of course.

I've submitted PR #37. In combination with PR #33, this gives users out of the box support for all screen sizes while allowing users the flexibility to customize to their hearts content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants