Use flex to automatically size optionContainer to its contents. #37

peacechen · 2017-01-27T23:17:12Z

This allows the modal contents to automatically fit any screen.

overlayStyle and cancelContainer adjusted accordingly to dynamically center content in a generic fashion.

fabriziomoscon · 2017-02-02T11:43:08Z

merged into my fork

peacechen · 2017-02-02T16:01:19Z

Thanks @fabriziomoscon. Do you publish your fork to NPM?

I noticed that you also removed flex:1 from selectStyle for RN 0.39 compatibility:
fabriziomoscon@423c8a0

I haven't tested against 0.39, but if you've vetted it I'll add that change to my PR.

fabriziomoscon · 2017-02-02T16:04:32Z

At the moment my package.json has this:

"react-native-modal-picker": "fabriziomoscon/react-native-modal-picker",

I am not planning to republish it under a different name.

Yes I tested it with RN 0.39.2 on android

- versions of react native < 0.39.0 should pass flex:1 explicitly to selectStyle as a prop. - Update Readme to reflect selectStyle prop change for RN 0.39.

Added changes from d-a-n#32 Added changes from d-a-n#37 Added changes from d-a-n#40 Added Properties (default): optionContainerStyle: ({}) optionNumberOfLines (undefined) optionEllipsizeMode (tail)

jaredtibs · 2017-05-15T01:39:16Z

Is there an update on getting this merged? In need of this functionality but would like to use the original repo.

fabriziomoscon · 2017-05-15T07:13:23Z

This repo is abandoned, I have cheery picked few PR from here in my fork since I am using this code in production.

Set the container prop `pointerEvents="none"` for children (content) to allow touches to `TextInput` to flow through.

Fixes sizing when rotating between landscape & portrait orientations.

* Prop to change supported orientation

* add base eslint rules and fix lint errors * add arbitrary eslint rules - key-spacing - no-empty-functions - comma-dangle rules to prevent runtime errors

Backwards compatible with RN pre-0.44.

* add support for configurable animationType * updated documentation

Update bitmap link and improve sample code.

Co-authored-by: HP <himanshu.patil@bizotics.com> Co-authored-by: Peace <github@ghpc.33mail.com>

Co-authored-by: Phil Taylor <phil@customd.com>

See #168 for description of error

* add option param to onModalClose type * export props

* update 1) updated expo version of sample app to 40.0.0 2) added typescript to sample app 3) converted sample app.tsx from class component to functional 4) fixed types issue * added more types

Resolves #176

Co-authored-by: Arthur Arakelyan <artur.araqelyan.2004@gmail.com>

Use flex to automatically size optionContainer to its contents.

00189fd

overlayStyle and cancelContainer adjusted accordingly to dynamically center content in a generic fashion.

peacechen mentioned this pull request Jan 27, 2017

Height optionContainer #27

Open

remove flex:1 from selectStyle to make the CSS work with RN39.

3bf0b7c

- versions of react native < 0.39.0 should pass flex:1 explicitly to selectStyle as a prop. - Update Readme to reflect selectStyle prop change for RN 0.39.

peacechen mentioned this pull request Jul 21, 2017

keyboardShouldPersisTaps={true} is deprecated, use keyboardShouldPersisTaps="always" instead #58

Open

peacechen added 3 commits August 8, 2017 11:23

Add prop keyboardShouldPersistTaps to pass to ScrollView.

880e5fb

Conditionally use ViewPropTypes.

849c0b8

Rename project

7fd3beb

peacechen force-pushed the master branch from 0dd327f to 7fd3beb Compare August 8, 2017 17:01

peacechen and others added 16 commits August 8, 2017 13:35

Update props in Readme

5ab3fec

Added NPM-version number and link to NPM-package (#3)

0b8c145

Update Readme

5e3efcc

Wrapping of TextInput works in iOS fixes #4 (#5)

b1456de

Set the container prop `pointerEvents="none"` for children (content) to allow touches to `TextInput` to flow through.

Add disabled prop to modal picker (#9)

2e90685

Support orientation and resolution changes (#10)

f31a3f6

Fixes sizing when rotating between landscape & portrait orientations.

Prop to change supported orientation (#11)

78576a7

* Prop to change supported orientation

Eslint rules (#15)

fd060c7

* add base eslint rules and fix lint errors * add arbitrary eslint rules - key-spacing - no-empty-functions - comma-dangle rules to prevent runtime errors

Typo in prop-type declaration

386a1c0

Removed react and react-native as devdependencies (#16)

0551493

Better way to support ViewPropTypes.

5821867

Backwards compatible with RN pre-0.44.

Upgrade SampleApp to RN 0.47 (#8)

860c259

Added prop for custom styling of options container (#21)

d9ad661

add support for configurable animationType (#22)

6eed2fa

* add support for configurable animationType * updated documentation

Readme: Pretty props table

0a48df1

Update bitmap link and improve sample code.

Update version for npm release

9850cab

tetianastepova and others added 29 commits August 19, 2020 14:32

Add ability to pass extra props to Cancel button text in modal (#149)

e65e933

Update NPM version to v2.0.3

6ef850f

Add eslint dev dependencies

a542528

Add listType prop to support FlatList or ScrollView (#157)

c552fef

Co-authored-by: HP <himanshu.patil@bizotics.com> Co-authored-by: Peace <github@ghpc.33mail.com>

Fix renderFlatlistOption() bug (should return renderOption result)

ef5a3a5

Readme: add listType prop

ceb5404

Fix prop types for web view in react native (#158) (#162)

32ba409

Co-authored-by: Phil Taylor <phil@customd.com>

2.0.4

34245a1

onChange should fire only for valid option with key (#140)

825d94d

2.0.5

8f32e08

Fix corner case onChange when key is 0

fc1c016

2.0.6

97913c5

Use keyExtractor in onChange() (#140)

479837e

2.0.7

844f2aa

TS: Add option param to onModalClose type (#166, #140)

79b9f15

2.0.8

a101cae

types: fix FlatList types

539673a

See #168 for description of error

Export props (#173)

90bb697

* add option param to onModalClose type * export props

docs: cleanup and added docs for methods

2bb5a45

Expo update and type fixes (#161)

4ec6925

* update 1) updated expo version of sample app to 40.0.0 2) added typescript to sample app 3) converted sample app.tsx from class component to functional 4) fixed types issue * added more types

v2.0.9

16b14dd

Add prop for rendering a header above the list

852b575

v2.1.0

a390266

chore: upgrade SampleApp to React 17

97d3fac

feat: add 'close()' to TypeScript typings

7d113b5

Resolves #176

chore: update babel / eslint

403f7ba

v2.1.1

930572d

Add onEndReached prop for FlatList (#180, #182)

d8de87f

Co-authored-by: Arthur Arakelyan <artur.araqelyan.2004@gmail.com>

2.1.2

202fb12

peacechen force-pushed the master branch from 6a2bb8d to 202fb12 Compare October 24, 2022 18:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use flex to automatically size optionContainer to its contents. #37

Use flex to automatically size optionContainer to its contents. #37

peacechen commented Jan 27, 2017

fabriziomoscon commented Feb 2, 2017

peacechen commented Feb 2, 2017 •

edited

Loading

fabriziomoscon commented Feb 2, 2017

jaredtibs commented May 15, 2017

fabriziomoscon commented May 15, 2017

Use flex to automatically size optionContainer to its contents. #37

Are you sure you want to change the base?

Use flex to automatically size optionContainer to its contents. #37

Conversation

peacechen commented Jan 27, 2017

fabriziomoscon commented Feb 2, 2017

peacechen commented Feb 2, 2017 • edited Loading

fabriziomoscon commented Feb 2, 2017

jaredtibs commented May 15, 2017

fabriziomoscon commented May 15, 2017

peacechen commented Feb 2, 2017 •

edited

Loading