Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes required to align with React 15.5 and React-Native 0.44 #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ktownsend-cbre
Copy link

React 15.5 moved PropTypes to its own module prop-types.
React-Native 0.44 deprecated View.propTypes in favor of ViewPropTypes.
ScrollView property keyboardShouldPersistTaps expects "always" value instead of implied value; currently just results in a warning.

As of react 15.5, PropTypes has moved to its own library.
Also fixed a warning about keyboardShouldPersistTaps needing to be "always" rather than {true}.
@ktownsend-cbre
Copy link
Author

I didn't notice all the open pull requests before submitting mine. Clearly this project has been abandoned.
I have switched to this active fork: https://github.com/peacechen/react-native-modal-selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant