Addition of multi-select feature. #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overlayStyle and cancelContainer adjusted accordingly to dynamically center content in a generic fashion.
- versions of react native < 0.39.0 should pass flex:1 explicitly to selectStyle as a prop. - Update Readme to reflect selectStyle prop change for RN 0.39.
Set the container prop `pointerEvents="none"` for children (content) to allow touches to `TextInput` to flow through.
Fixes sizing when rotating between landscape & portrait orientations.
* Prop to change supported orientation
* add base eslint rules and fix lint errors * add arbitrary eslint rules - key-spacing - no-empty-functions - comma-dangle rules to prevent runtime errors
Backwards compatible with RN pre-0.44.
* add support for configurable animationType * updated documentation
Update bitmap link and improve sample code.
* reverted style changes introduced in orientation fixes * Updated style changes to correctly support cancel button * reduced padding to 5% * Updated overlayStyle in readme
* Optionally close the modal by pressing the overlay In response to Close Modal on overlay click peacechen#28 peacechen#28 I have made it possible to pass a prop to the component ('backdropPressToClose', boolean, default value is false) which when true will close the modal but calling the close() method, just as pressing the 'cancel' button in the modal does.
* Added backdropPressToClose to documentation
* Update Modal propTypes due to deprecation in RN 0.58+
* Add selectedKey prop * Update Readme
* Add initValueTextStyle prop
Add Git-Start links to Readme
Fixes Expo issue when displaying the modal where the TouchableWithoutFeedback was causing a problem due to a RN bug in older versions (peacechen#118)
* added type definitions * fix space * label extractor returns string * label optional for data item * added markdown to type summary, added correct type for key property
* Add selected item to onModalClose function
- Added multi select option. - Added husky, making auto linting possible. - Upgraded RN to the latest version.
allroundexperts
force-pushed
the
master
branch
from
1d4d858
to
cc18e96
Compare
added 6 commits
December 22, 2019 22:42
This reverts commit ac29629.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: Messed up the previous PR so created a new one.