Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(seed-docs): update spinner/style.mdx #331

Merged
merged 4 commits into from
Aug 11, 2023
Merged

docs(seed-docs): update spinner/style.mdx #331

merged 4 commits into from
Aug 11, 2023

Conversation

stleamist
Copy link
Member

No description provided.

@stleamist stleamist requested a review from a team August 11, 2023 01:33
@stleamist stleamist self-assigned this Aug 11, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ad8ffac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Deploy Seed Docs Alpha Pages / Deploy Seed Docs (push) CI가 성공적으로 끝나면 해당 링크로 이동해서 preview를 확인해요 -> https://dash.cloudflare.com/aad5c82543cd1f267b89737d0f56405e/pages/view/seed-design

Nanamare
Nanamare approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Nanamare Nanamare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. mdx preview 설치해서 봤네요 ㅋ.ㅋ
from, to, part 3개 속성은 따로 테이블 분리해도 괜찮을 것 같기도 하네요.
LGTM 🥇

@stleamist stleamist requested a review from a team August 11, 2023 03:34
@stleamist stleamist merged commit c90ca7d into main Aug 11, 2023
3 checks passed
@stleamist stleamist deleted the docs/update-spinner-style branch August 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nanamare Nanamare Nanamare approved these changes

Assignees

@stleamist stleamist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stleamist @Nanamare @junghyeonsu