Integrate OpenWeatherMap API #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daawaan4U
changed the title
daawaan4U
requested changes
May 18, 2024
There was a problem hiding this comment.
I left a comment on the GeoMap component.
I think you were not able to commit all your changes from your local end (?) since the implementation for the API requests are missing.
Also, you can format your changes with mvn formatter:format to satisfy the PR check
daawaan4U
previously requested changes
May 25, 2024
There was a problem hiding this comment.
Left some comments around on the edited files. Aside from that:
- For the formatter check, you can fix them with
mvn formatter:format. - For the
yourpackagefolder, I think we can rename it with a more fitting name such asapi(?) folder instead. - The previous comments & java docs on some parts were removed and are still left unchanged, I do not know if this is intentional.
P.S. my DMs are open anytime, ask for any Qs or help lang if needed 🫡
src/main/java/edu/project/yourpackage/WeatherForecast5Data.java
Outdated
Show resolved
Hide resolved
geilala
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all tasks given... i might have missed to pr some other changes cuzz im having trouble making PR just DM if found some error or mistake, our net is now good so i can fix anything ASAP if needed