Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flutter version 3.22.2 #46

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Upgrade flutter version 3.22.2 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dd68d3
Update intl to 0.19.0
tddang-linagora Jul 9, 2024
bdcce12
Upgrade Flutter to 3.22.2
tddang-linagora Jul 12, 2024
484bf8a
Add `FLUTTER_VERSION` on env property in CI
dab246 Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/analyze-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on:

name: Analyze and test

env:
FLUTTER_VERSION: 3.22.2

jobs:
analyze-test:
runs-on: ubuntu-latest
Expand All @@ -20,7 +23,7 @@ jobs:
- name: Setup flutter
uses: subosito/flutter-action@v2
with:
flutter-version: "3.16.0"
flutter-version: ${{ env.FLUTTER_VERSION }}
channel: "stable"

- name: Run prebuild
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:

name: CI

env:
FLUTTER_VERSION: 3.22.2

jobs:
analyze-test:
name: Analyze and test
Expand All @@ -23,7 +26,7 @@ jobs:
- name: Setup flutter
uses: subosito/flutter-action@v2
with:
flutter-version: "3.16.0"
flutter-version: ${{ env.FLUTTER_VERSION }}
channel: "stable"

- name: Run prebuild
Expand Down
12 changes: 6 additions & 6 deletions lib/tag_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import 'package:debounce_throttle/debounce_throttle.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:super_tag_editor/suggestions_box_controller.dart';
import 'package:pointer_interceptor/pointer_interceptor.dart';
import 'package:super_tag_editor/suggestions_box_controller.dart';
import 'package:super_tag_editor/utils/direction_helper.dart';
import 'package:super_tag_editor/widgets/validation_suggestion_item.dart';

Expand All @@ -26,7 +26,7 @@ typedef SearchSuggestions<T> = FutureOr<List<T>> Function();
typedef OnDeleteTagAction = Function();
typedef OnFocusTagAction = Function(bool focused);
typedef OnSelectOptionAction<T> = Function(T data);
typedef OnHandleKeyEventAction = Function(RawKeyEvent event);
typedef OnHandleKeyEventAction = Function(KeyEvent event);
typedef OnFocusTextInputFieldCallback = Function();

/// A [Widget] for editing tag similar to Google's Gmail
Expand Down Expand Up @@ -662,10 +662,10 @@ class TagsEditorState<T> extends State<TagEditor<T>> {
return textPainter.width;
}

void _handleKeyboardEvent(RawKeyEvent event) {
void _handleKeyboardEvent(KeyEvent event) {
widget.onHandleKeyEventAction?.call(event);

if (event is RawKeyDownEvent) {
if (event is KeyDownEvent) {
switch (event.logicalKey) {
case LogicalKeyboardKey.backspace:
_onKeyboardBackspaceListener();
Expand Down Expand Up @@ -775,9 +775,9 @@ class TagsEditorState<T> extends State<TagEditor<T>> {
LayoutId(
id: TagEditorLayoutDelegate.textFieldId,
child: widget.focusNodeKeyboard != null
? RawKeyboardListener(
? KeyboardListener(
focusNode: widget.focusNodeKeyboard!,
onKey: _handleKeyboardEvent,
onKeyEvent: _handleKeyboardEvent,
child: textInputField,
)
: textInputField)
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:

debounce_throttle: ^2.0.0

intl: ^0.18.0
intl: ^0.19.0

dev_dependencies:
flutter_test:
Expand Down
Loading