Skip to content

Commit

Permalink
Switch our requests pin to only exclude 2.32.0
Browse files Browse the repository at this point in the history
Both docker-py and requests have fixes in flight. We can narrow our pin
to only exclude the breaking version.

docker/docker-py#3257
psf/requests#6707 (comment)
  • Loading branch information
jmsanders committed May 21, 2024
1 parent c4ea9e6 commit 505720d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ sqlalchemy<2.0.0
# Added pendulum pin in later versions
pendulum<3

# 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
requests<2.32.0
# https://github.com/dagster-io/dagster/pull/21977
requests!=2.32.0
2 changes: 1 addition & 1 deletion python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def get_version() -> str:
"morefs[asynclocal]",
"fsspec<2024.5.0", # morefs incompatibly
"rapidfuzz",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
],
"mypy": ["mypy==1.8.0"],
"pyright": [
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-celery-docker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def get_version() -> str:
f"dagster-celery{pin}",
f"dagster-graphql{pin}",
"docker",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
],
zip_safe=False,
)
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-docker/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def get_version() -> str:
f"dagster{pin}",
"docker",
"docker-image-py",
"requests<2.32.0", # 2.32.0 breaks our docker tests https://buildkite.com/dagster/dagster-dagster/builds/83562
"requests!=2.32.0", # https://github.com/dagster-io/dagster/pull/21977
],
zip_safe=False,
)

0 comments on commit 505720d

Please sign in to comment.