-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to new docs "Build" section #26878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
neverett
changed the title
Updates to new docs 'build' section
Updates to new docs "Build" section
Jan 7, 2025
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
…izing assets article, update links Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
… isn't documented Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
Signed-off-by: nikki everett <nikki@dagsterlabs.com>
cmpadden
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to keep the ball rolling.
I can assist with python file=*.py
-> CodeExample
while you focus on content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Move missing content into "Build" section of new docs and edit for clarity.
Most content has been moved, although there are a few TODOs left, and a handful of empty files left over from before I got here that are a bit of a mystery.
We will also need to fix the code examples—in lots of places, the code was copy/pasted straight from the old docs mdx file, but those should be turned into
<CodeExample>s
(and the corresponding code moved into the correct snippets directory). I think we should get all the code samples in one sweep later, though, so we can concentrate on getting content moved as quickly as possible.How I Tested These Changes
Local build.
Changelog