Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetProgress is avoiding quartileEvents to be fired several times #460

Closed
rs-guian opened this issue Oct 7, 2023 · 6 comments
Closed

SetProgress is avoiding quartileEvents to be fired several times #460

rs-guian opened this issue Oct 7, 2023 · 6 comments

Comments

@rs-guian
Copy link
Contributor

rs-guian commented Oct 7, 2023

vast-client-js 5.0.0

Using the VPAIDTracker to call event urls.
We have the setProgress call on video progress, this fires quartile automatically wich is convenient.
issue is :

Some of or publishers are using a replay button so the ad can be rewound. setProgress is calling the "rewind" event as expected but then the quatile events are not fired anymore.

This is because the setProgress event is setting "once: true" on track() call which removes the tracking urls from the url array.
To avoid this we trigger quartile urls directly with track() and avoid using setProgress.

can we add a parameter on setProgress ( 'trackOnce' = true ) so anyone can set it to false if needed please ?

made the pull request here : #461

@Rapha0511
Copy link
Contributor

Rapha0511 commented Oct 16, 2023

Hello ! Thanks for raising this issue :)

This is an interesting feature to add since it does not modify the initial behavior of the setProgress() function and it allows more adaptability for specific needs.

I will look further into your pull request. :)

@rs-guian
Copy link
Contributor Author

Seen the pull request be merged.
When will it be available ? Is next release planned yet ?

@Rapha0511
Copy link
Contributor

It will be available in the coming weeks :)

@rs-guian
Copy link
Contributor Author

Hello dailymotion team.

I came here to get updates. Is there a planned 5.1 release that includes the fix I submitted?

@Rapha0511
Copy link
Contributor

Hello!

A major update will be release in february. You can see the changes on this pull request .

The change you submitted has been merged to master and will be available in the next release of the vast-client. :)

@ZacharieTFR
Copy link
Contributor

Hello, closing this issue as it has been fixed in 6.0.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants