Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where fallback was not working if first ad element return empty #466

Merged
merged 1 commit into from
Jun 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parser/vast_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ export class VASTParser extends EventEmitter {
return Promise.all(resolveWrappersPromises).then((unwrappedAds) => {
const resolvedAds = util.flatten(unwrappedAds);

if (!resolvedAds && this.remainingAds.length > 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

!0 = true
!(non zero length) = false

if (!resolvedAds.length && this.remainingAds.length > 0) {
const remainingAdsToResolve = this.remainingAds.shift();

return this.resolveAds(remainingAdsToResolve, {
Expand Down