Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 7.1 #42

Merged
merged 8 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 7 additions & 59 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,63 +9,6 @@ on:
- master

jobs:
legacy:
runs-on: ubuntu-18.04
services:
mysql:
image: mysql:5.5
env:
MYSQL_ROOT_PASSWORD: pass
ports:
- "3306:3306"
options: >-
--health-cmd="mysqladmin ping"
--health-interval=10s
--health-timeout=5s
--health-retries=3

name: ruby-${{ matrix.ruby }} ${{ matrix.gemfile }}
strategy:
matrix:
include:
- gemfile: rails3.0
ruby: 2.4
- gemfile: rails3.1
ruby: 2.4
- gemfile: rails3.2
ruby: 2.4

- gemfile: rails4.0
ruby: 2.4
- gemfile: rails4.1
ruby: 2.4
- gemfile: rails4.2
ruby: 2.4

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true

steps:
- uses: actions/checkout@master

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler: default
bundler-cache: true

- name: Set up database
run: |
cp spec/support/config.yml.github spec/support/config.yml
bundle exec rake db:create

- name: Run tests
run: |
bundle exec rspec spec


latest:
runs-on: ubuntu-latest
services:
Expand Down Expand Up @@ -101,10 +44,15 @@ jobs:
- gemfile: rails6.1
ruby: 3.0

- gemfile: rails7.0
ruby: 2.7
- gemfile: rails7.0
ruby: 3.0
- gemfile: rails7.0
ruby: 3.1

- gemfile: rails7.1
ruby: 3.1
- gemfile: rails7.1
ruby: 3.2

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.2
3.2.2
14 changes: 4 additions & 10 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,29 +1,23 @@
appraise "rails5.1" do
gem "activerecord", "~> 5.1.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"
end

appraise "rails5.2" do
gem "activerecord", "~> 5.2.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"
end

appraise "rails6.0" do
gem "activerecord", "~> 6.0.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"
end

appraise "rails6.1" do
gem "activerecord", "~> 6.1.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"
end

appraise "rails7.0" do
gem "activerecord", "~> 7.0.0"
gem "mysql2", "~> 0.5"
gem "sqlite3", "~> 1.4"
end

appraise "rails7.1" do
gem "activerecord", "~> 7.1.0"
end
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change log

## 0.5.0 2023-10-27

- Add support for Rails 7.1
- Drop legacy test job because ubuntu-18.04 build node is not available anymore

## 0.4.0 2022-02-12

- Add support for Rails 7.0
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source 'https://rubygems.org'
gem "activerecord", "~> 7.0.0"
gem "activerecord", "~> 7.1.0"

# Specify your gem's dependencies in octoshark.gemspec
gemspec
9 changes: 0 additions & 9 deletions gemfiles/rails3.1.gemfile

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/rails3.2.gemfile

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/rails4.0.gemfile

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/rails4.1.gemfile

This file was deleted.

9 changes: 0 additions & 9 deletions gemfiles/rails4.2.gemfile

This file was deleted.

2 changes: 0 additions & 2 deletions gemfiles/rails5.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@
source "https://rubygems.org"

gem "activerecord", "~> 5.1.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"

gemspec path: "../"
2 changes: 0 additions & 2 deletions gemfiles/rails5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@
source "https://rubygems.org"

gem "activerecord", "~> 5.2.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"

gemspec path: "../"
2 changes: 0 additions & 2 deletions gemfiles/rails6.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@
source "https://rubygems.org"

gem "activerecord", "~> 6.0.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"

gemspec path: "../"
2 changes: 0 additions & 2 deletions gemfiles/rails6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@
source "https://rubygems.org"

gem "activerecord", "~> 6.1.0"
gem "mysql2", "~> 0.5.2"
gem "sqlite3", "~> 1.4.1"

gemspec path: "../"
2 changes: 0 additions & 2 deletions gemfiles/rails7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,5 @@
source "https://rubygems.org"

gem "activerecord", "~> 7.0.0"
gem "mysql2", "~> 0.5"
gem "sqlite3", "~> 1.4"

gemspec path: "../"
4 changes: 1 addition & 3 deletions gemfiles/rails3.0.gemfile → gemfiles/rails7.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

source "https://rubygems.org"

gem "activerecord", "~> 3.0.0"
gem "mysql2", "< 0.3"
gem "sqlite3", "~> 1.3.13"
gem "activerecord", "~> 7.1.0"

gemspec path: "../"
1 change: 1 addition & 0 deletions lib/octoshark/connection_pools_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def create_connection_pool(name, config)
def build_connection_pool_spec(name, config)
if active_record_6_1_or_7?
env_name = defined?(Rails) ? Rails.env : nil
require "active_record/database_configurations"
db_config = ActiveRecord::DatabaseConfigurations::HashConfig.new(env_name, name, config)

pool_config_class = ActiveRecord::ConnectionAdapters::PoolConfig
Expand Down
2 changes: 1 addition & 1 deletion lib/octoshark/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Octoshark
VERSION = "0.4.0"
VERSION = "0.5.0"
end
2 changes: 1 addition & 1 deletion octoshark.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency "activerecord", ">= 3.0"

spec.add_development_dependency "rake"
spec.add_development_dependency "rspec", "~> 3.7.0"
spec.add_development_dependency "rspec", "~> 3.12.0"
spec.add_development_dependency "sqlite3", "~> 1.4.1"
spec.add_development_dependency "mysql2", "~> 0.5.2"
spec.add_development_dependency "appraisal"
Expand Down
2 changes: 0 additions & 2 deletions spec/support/config.yml.github
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
db1:
adapter: mysql2
encoding: utf8
reconnect: false
database: octoshark_db1
pool: 5
username: root
Expand All @@ -12,7 +11,6 @@ db1:
db2:
adapter: mysql2
encoding: utf8
reconnect: false
database: octoshark_db2
pool: 5
username: root
Expand Down
2 changes: 0 additions & 2 deletions spec/support/config.yml.template
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
db1:
adapter: mysql2
encoding: utf8
reconnect: false
database: octoshark_db1
pool: 5
username: root
Expand All @@ -12,7 +11,6 @@ db1:
db2:
adapter: mysql2
encoding: utf8
reconnect: false
database: octoshark_db2
pool: 5
username: root
Expand Down