-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2122 from dandi/display-validation-errors-for-emb…
…argoed Display validation errors on DLP for embargoed dandisets
- Loading branch information
Showing
4 changed files
with
161 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152 changes: 152 additions & 0 deletions
152
web/src/views/DandisetLandingView/DandisetValidationErrors.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| <template> | ||
| <v-container> | ||
| <v-row | ||
| v-if="dandiset.status === 'Pending'" | ||
| class="my-2 px-1" | ||
| no-gutters | ||
| > | ||
| <v-menu | ||
| :nudge-width="200" | ||
| > | ||
| <template #activator="{ on: menu, attrs }"> | ||
| <v-tooltip bottom> | ||
| <template #activator="{ on: tooltip }"> | ||
| <v-card | ||
| class="amber lighten-5 no-text-transform" | ||
| outlined | ||
| v-bind="attrs" | ||
| v-on="{ ...tooltip, ...menu }" | ||
| > | ||
| <v-row class="align-center px-4"> | ||
| <v-col | ||
| cols="1" | ||
| class="justify-center py-0" | ||
| > | ||
| <v-icon | ||
| color="warning" | ||
| class="mr-1" | ||
| > | ||
| mdi-playlist-remove | ||
| </v-icon> | ||
| </v-col> | ||
| <v-spacer /> | ||
| <v-col cols="9"> | ||
| <div class="text-caption"> | ||
| Validation of the dandiset is pending. | ||
| </div> | ||
| </v-col> | ||
| </v-row> | ||
| </v-card> | ||
| </template> | ||
| <span>Reload the page to see if validation is over.</span> | ||
| </v-tooltip> | ||
| </template> | ||
| </v-menu> | ||
| </v-row> | ||
|
|
||
| <!-- Dialog where version and asset errors are shown --> | ||
| <v-dialog v-model="errorDialogOpen"> | ||
| <ValidationErrorDialog | ||
| :selected-tab="selectedTab" | ||
| :asset-validation-errors="dandiset.asset_validation_errors" | ||
| :version-validation-errors="dandiset.version_validation_errors" | ||
| :owner="isOwner" | ||
| @openMeditor="openMeditor" | ||
| /> | ||
| </v-dialog> | ||
|
|
||
| <!-- Version Validation Errors Button --> | ||
| <v-card | ||
| v-if="dandiset.version_validation_errors.length" | ||
| class="my-2 px-1 amber lighten-5 no-text-transform" | ||
| outlined | ||
| @click="openErrorDialog('metadata')" | ||
| > | ||
| <v-row class="align-center px-4"> | ||
| <v-col | ||
| cols="1" | ||
| class="justify-center py-0" | ||
| > | ||
| <v-icon | ||
| color="warning" | ||
| class="mr-1" | ||
| > | ||
| mdi-playlist-remove | ||
| </v-icon> | ||
| </v-col> | ||
| <v-spacer /> | ||
| <v-col cols="9"> | ||
| <div class="text-caption"> | ||
| This Dandiset has {{ dandiset.version_validation_errors.length }} | ||
| metadata validation error(s). | ||
| </div> | ||
| </v-col> | ||
| </v-row> | ||
| </v-card> | ||
|
|
||
| <!-- Asset Validation Errors Button --> | ||
| <v-card | ||
| v-if="numAssetValidationErrors" | ||
| class="my-2 px-1 amber lighten-5 no-text-transform" | ||
| outlined | ||
| @click="openErrorDialog('assets')" | ||
| > | ||
| <v-row class="align-center px-4"> | ||
| <v-col | ||
| cols="1" | ||
| class="justify-center py-0" | ||
| > | ||
| <v-icon | ||
| color="warning" | ||
| class="mr-1" | ||
| > | ||
| mdi-database-remove | ||
| </v-icon> | ||
| </v-col> | ||
| <v-spacer /> | ||
| <v-col cols="9"> | ||
| <div class="text-caption"> | ||
| This Dandiset has {{ numAssetValidationErrors }} | ||
| asset validation error(s). | ||
| </div> | ||
| </v-col> | ||
| </v-row> | ||
| </v-card> | ||
| </v-container> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { computed, defineProps, ref} from 'vue'; | ||
| import type { PropType } from 'vue'; | ||
| import ValidationErrorDialog from '@/components/DLP/ValidationErrorDialog.vue'; | ||
| import { open as meditorOpen } from '@/components/Meditor/state'; | ||
| import type { Version } from '@/types'; | ||
| const props = defineProps({ | ||
| dandiset: { | ||
| type: Object as PropType<Version>, | ||
| required: true, | ||
| }, | ||
| isOwner: { | ||
| type: Boolean as PropType<boolean>, | ||
| required: true, | ||
| }, | ||
| }); | ||
| const numAssetValidationErrors = computed(() => props.dandiset.asset_validation_errors.length); | ||
| // Error dialog | ||
| const errorDialogOpen = ref(false); | ||
| type ErrorCategory = 'metadata' | 'assets'; | ||
| const selectedTab = ref<ErrorCategory>('metadata'); | ||
| function openErrorDialog(tab: ErrorCategory) { | ||
| errorDialogOpen.value = true; | ||
| selectedTab.value = tab; | ||
| } | ||
| function openMeditor() { | ||
| errorDialogOpen.value = false; | ||
| meditorOpen.value = true; | ||
| } | ||
| </script> |