Make logging level of the django app configurable #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATM we do not have a single DEBUG level log statement, but I hope that logging would be enriched. Adding such control would also allow to make log less talkative if so desired by setting it to WARNING level. But also would simplify addition and use of new log statements
yarikoptic
added
DX
These are not needed here, as they are already part of the setting definition (that is, `settings.DANDI_LOG_LEVEL` always exists and has the correct default value if it is not set explicitly).
The [`logging` module docs](https://docs.python.org/3/library/logging.html#logging.Logger.setLevel) explain that `setLevel()` can handle the string representations of the logging levels. This allows the setting value to be directly tied to what is passed in, and `setLevel()` also does a "validation" on the value and will refuse to process levels that don't exist.
waxlamp
reviewed
Dec 13, 2024
This needs to be `logging.INFO` so that Sentry can propery construct breadcrumbs within its error reports.
waxlamp
reviewed
Dec 13, 2024
yarikoptic
commented
Dec 17, 2024
waxlamp
approved these changes
Jan 2, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM we do not have a single DEBUG level log statement, but I hope that logging would be enriched. Adding such control would also allow to make log less talkative if so desired by setting it to WARNING level. But also would simplify addition and use of new log statements. E.g. I would right away add it into dandi-cli docker-compose setup so to help in the future troubleshooting issues like