Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instruction to natively(locally) run Celery service #2105

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

candleindark
Copy link
Member

See commit for details

Update it so that it corresponds exactly as the celery
service defined in `docker-compose.override.yml`
@candleindark
Copy link
Member Author

Don't know why the build-image test failed. Don't have a permission to re-run it. It could be a glitch.

Error from the test:

Run docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN"
  docker login -u "$DOCKER_LOGIN" --password-stdin <<<"$DOCKER_TOKEN"
  docker build \
    -t dandiarchive/dandiarchive-api \
    -f dev/django-public.Dockerfile \
    .
  shell: /usr/bin/bash -e {0}
  env:
    DOCKER_LOGIN: 
    DOCKER_TOKEN: 
Must provide --username with --password-stdin
Error: Process completed with exit code 1.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I believe CI is failing due to the candleindark/dandi-archive repo not having access to the github actions secrets for logging into docker hub. I'll make and issue for that and merge this PR into another branch within the dandi/dandi-archive repo and see if that fixes it.

@mvandenburgh mvandenburgh changed the base branch from master to update-readme December 11, 2024 14:30
@mvandenburgh mvandenburgh merged commit b6913bb into dandi:update-readme Dec 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants