-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sub-package "time series" into PlantCV #587
Open
DannieSheng
wants to merge
286
commits into
visualize_show_instances
Choose a base branch
from
add_time_series_sub_package
base: visualize_show_instances
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a sub-package "time series" into PlantCV #587
DannieSheng
wants to merge
286
commits into
visualize_show_instances
from
add_time_series_sub_package
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannieSheng
added
documentation
Documentation issues or features
new feature
New feature ideas and solutions
work in progress
Mark work in progress
labels
Jun 17, 2020
for the newly added time_lapse_video function into visualize subpackage
for the newly added time_lapse_video into visualize subpackage
for the newly added time_lapse_video into visualize subpackage
Update tests for visualize/time_lapse_video
8 tasks
- remove unused methods; - change from `get_uid` to `get_sorted_uids`; - change from `get_emergence` to `get_emerg_disap_info`; - update `get_ti` method - add static method `update_ti` that is used to update time-series tracking by comparing timepoints whose distance is greater than 1.
…ngs for multiple methods
…d when `update_ti` is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Documentation issues or features
new feature
New feature ideas and solutions
work in progress
Mark work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A brand new sub-package called "time series" was added to PlantCV.
This package is different from most functions already in PlantCV, it deals not with single images, but a series of images. Related documentation, tests, and test data are also updated.
class
InstanceTimeSeriesLinking
(methods are called by the methods inside the parentheses )
(checklist for whether have tests covered)
class methods:
save_linked_series
import_linked_series
link_t
(link
)link
update_ti
link_dist_t
(link_dist
)link_dist
static methods:
get_link
(_update_ti
,link_t
,link_dist_t
)compute_overlaps_weights
(link_t
,_update_ti
)get_sorted_uids
(link
,link_dist
)get_uids_from_ti
(_update_ti
)get_emerg_disap_info
(get_ti
,_update_ti
)get_ti
(link
,link_dist
)get_li_from_ti
area_tracking_report
(link
,update_ti
)visualize
_update_ti
(update_ti
)compute_dist_weights
(link_dist_t
)Type of update
Is this a: