Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set units for shock setup #481

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Set units for shock setup #481

merged 3 commits into from
Nov 27, 2023

Conversation

themikelau
Copy link
Collaborator

  • Interactive setup now prompts for mass and length units
  • Units now written into and read from setup file

@themikelau
Copy link
Collaborator Author

@danieljprice Some of the tests involving integration of binary orbit in the testptmass module seem to have failed because they exceeded a maximum runtime of the workflow. I don't see how the changes I have made would have caused this. Any ideas on how to get the tests to pass?

Copy link
Owner

@danieljprice danieljprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themikelau can you explain the motivation for this change? In general we should NOT set units for shock tube problems, since they are scale-free problems. The only way units change anything is if you have radiation or other physics that depends on the actual temperature. Hence my strong preference would be to only set units for the cases where this is useful i.e. if (do_radiation).

Otherwise simple test problems become confusing to the user, especially since splash will present things in physical units by default if they are set...

@themikelau themikelau marked this pull request as draft November 20, 2023 07:14
@themikelau
Copy link
Collaborator Author

@danieljprice Thanks for the review. Indeed I added this for running a radiation-dominated shock. I will add if (do_radiation) around my changes.

@themikelau themikelau marked this pull request as ready for review November 20, 2023 09:09
@danieljprice
Copy link
Owner

I have raised an issue on the slow actions, #484 , looking into it but this is currently blocking merge (I have rerun all tests and same issue). Affecting both currently open pull requests, so it's nothing from the proposed merges, either something from a previous merge or something changed on the actions runners...

@danieljprice danieljprice merged commit 8c0857f into master Nov 27, 2023
164 of 177 checks passed
@danieljprice danieljprice deleted the shock branch November 27, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants