-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(build) add aocc installation #532
base: master
Are you sure you want to change the base?
Conversation
Thanks for this Mike!
|
Thanks for the clarification, @danieljprice. Good to know the test is successfully failing. I will first start with a replacement of findloc. I think it can be replaced in-line using other intrinsic functions like minloc or maxloc, without having to write new subroutines. This is worth doing since findloc hasn't been used in other places, and it is desirable to quickly implement an aocc build test before we push more aocc compiler errors. |
@@ -403,13 +403,13 @@ subroutine find_hier_level_orb_elem(hl_temp, hs, m1, m2, accr1, accr2, & | |||
!print *,'labels passing: ', trim(adjustl(hl_temp))//'1 ', m1,trim(adjustl(hl_temp))//'2 ',m2 | |||
|
|||
if (any(hs%labels%sink == trim(adjustl(hl_temp))//'1')) then | |||
accr1 = hs%sinks(findloc(hs%labels%sink,trim(adjustl(hl_temp))//'1', 1))%accr | |||
accr1 = hs%sinks( maxloc( merge(0,1,hs%labels%sink==trim(adjustl(hl_temp))//'1' ), 1) )%accr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest to at least write a helper function here like findloc_nof08 to avoid repeated code
Type of PR:
Bug fix / new physics / modification to existing code / other
Description:
Give a short description of the change.
Testing:
Describe how you have tested the change
Did you run the bots? yes/no
Did you update relevant documentation in the docs directory? yes/no