Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tillotson cleanup and testing #609

Merged
merged 74 commits into from
Dec 20, 2024
Merged

Tillotson cleanup and testing #609

merged 74 commits into from
Dec 20, 2024

Conversation

danieljprice
Copy link
Owner

Type of PR:
new physics

Description:

  • cleanup and testing of Tillotson EOS #593
  • added new unit tests for all equations of state, checking pressure is continuous with density and thermal energy
  • new add_body routine for SETUP=solarsystem to add bodies individually

Testing:

make SETUP=star phantomtest && ./bin/phantomtest eos

Did you run the bots? yes

Did you update relevant documentation in the docs directory? yes

Ambionce and others added 30 commits August 7, 2024 11:26
@Ambionce
(tillotson) added module and subroutines for tillotson eos
4303043
@Ambionce
merge
7131412
@Ambionce
(Tillotson) wrote psuedocode for EOS
ea43d24
@Ambionce
(units) added earth radii to unit options
91c9f0d
@Ambionce
(units) added earth radii to unit options
9db149c
@Ambionce
(tillotson) added psuedocode - tillotson eos parameters for basalt an…
c8c7280 
…d ice
@Ambionce
(tillotson) compiled code and params for basalt from benz & asphaug 1999
93466fa
@Ambionce
(tillotson) added initialise eos case 23 subroutine
665fcb3
@Ambionce
(tillotson) update init and read eos subroutines for case 23
00c42fe
@Ambionce
(tillotson) updated eos and readwrite infile to include case 23 eos
bf14df6
@Ambionce
(tillotson) remove unit conversion from write options eos
03f8493
@Ambionce
(setup_solarsystem) added mass of sun in binary system setup
cd8df39
@Ambionce
(setup_binary) removed hardcoded eos in subroutine
0a5f901
@Ambionce
(tillotson) fixed units read-write functions and updated condensed-ev…
19a988b 
…aporated cases
@Ambionce
(tillotson) added calculation of temp to internal energy to eos subro…
14b9bc2 
…utine call
@Ambionce
(solarsystem) included asteroid apophis into ephemeris and solarsyste…
5063782 
…m setup
@Ambionce
Merge remote-tracking branch 'origin' into Tillotson
73c34cb 
Mega-merge-update
@Ambionce
(tillotson) fix windows crap
03b50a9
@Ambionce
(solarsystem) initial change from multiple binary setups to single st…
db69327 
…ar with particles setup
@Ambionce
(tillotson) update eos to include hybrid phase and fix greek paramete…
a7ad58f 
…r errors
@Ambionce
(tillotson) updated internal energy calculation
40d7cb2
@Ambionce
(tillotson) updated pressure and energy conditional calculations
fa0b709
@Ambionce
(tillotson) quadratic equation fix for internal energy subroutine
4eec9e7
@Ambionce
(tillotson) in Makefile changed order for reading in cubicsolve
211829a
@Ambionce
(tillotson) update piecewise pressure and internal energy
3bf2555
@Ambionce
(tillotson) add calc u from prho to testing suite
47d5663
@AmberTilly
Merge branch 'danieljprice:master' into Tillotson
56d18c4
@Ambionce
(tillotson) removed unnecessary code
e3091aa
@Ambionce
(Tillotson) updated eos piecewise and testing of eos
6e4764f
@Ambionce
(tillotson) fixed piecewise eos to within 1.E-12 tol
5034e52
@danieljprice
[indent-bot] standardised indentation
e1ff4e8
@danieljprice
(docs) update documentation
a8e77a2
@danieljprice
merge conflict fixed
efb71b6
@danieljprice
(test_eos) fix test failure due to uninitialised variable
f4f35a6
@danieljprice
(tillotson) update docs with eos details
a6be532
@danieljprice
(solarsystem) cleanup functionality into set_bodies module; add optio…
77f10e6 
…ns for minor bodies, planets etc, add option for epoch when retrieving ephemeris, fix bugs in ephemeris read
@danieljprice
(checksetup) check for NaNs in sink particle arrays
ca78095
@danieljprice
(utils_dumpfiles) out of bounds error fixed if there are no SPH parti…
0231c97 
…cles
@danieljprice
(substep) do not call update_ptmass if nothing has been accreted; als…
ac0777a 
…o handle case where sink mass is initially zero
@danieljprice
(checksetup) seg fault fixed from apr stuff left in checksetup routine
71f8203
@danieljprice
(solarsystem) working simulation of impending destruction
d2dc2bf
@danieljprice
(ephemeris) added setup for dwarf planets
f2847e5
@danieljprice
(test_eos) compiler warning fixed
376a98e
@danieljprice
(solarsystem) add gravity, option for number of particles in body
f72d676
@danieljprice
(eos) added eos_requires_polyk routine instead of hardwiring eos opti…
a3f0aec 
…ons in checksetup routine; also fix accounting in identical positions check
@danieljprice
(setup) bug fixed in setup; use closepacked lattice; nptot no longer …
6110247 
…optional in call to set_sphere to avoid seg fault
@danieljprice
(set_sphere) test failures fixed
7948ddc
@danieljprice
(test_ptmass) bug fix with previous fix for zero-mass sinks; tighten …
c003cb6 
…tolerances in disc tests
@danieljprice
(test_ptmass) revert changes to tolerances
8cdebf8
@danieljprice
(eos) tillotson outputs pressure to dump file
02fd8ec
@danieljprice
(apr) bug fix with mpi_dens extent calculation; also make this a fata…
1854e41 
…l error so it flags in test suite
@danieljprice
(ptmass) fix test failure with MPI
542f401
@danieljprice
(mpi) added bcast_mpi_logical routine
7d9ff16
@danieljprice
(test_ptmass) BUG FIX with epot_sinksink causing test failure with MP…
ef9b449 
…I in ptmassSDAR test; single values now correctly reduced across mpi threads in the checkval routine
@danieljprice
(header) amend header to reflect collaborative authorship of Phantom
0ccbae3
@danieljprice
(mpi) test failure fixed
ee1e177
@danieljprice
(mpi) hangs in testsuite with checks on single thread fixed
8905290
@danieljprice
(build) build failures fixed
34c4792
@danieljprice danieljprice merged commit 14141c7 into master Dec 20, 2024
180 checks passed
@danieljprice danieljprice deleted the tillotson branch December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljprice @Ambionce @AmberTilly