Tweaks to original Interval PR #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to add years and months, store interval specification string to database, instead of seconds.
latest core master changes
|
Thanks @lrodneywu for your works, I am using your version which is working well. |
|
@lrodneywu - just came back to this and I see that it doesn't run an upgrade to fix any existing durations set by any existing recompletions - any chance you would be able to write an upgrade script to convert existing config settings to the new version? |
|
closing old PR that conflicts with upstream code - happy for someone to rebase this and fix the upgrade script though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We too quite keenly require the functionality as described in this issue #17, so having noticed that there hasn't been any recent movement from https://github.com/duranchen (the orignal author), have implemented the suggested changes from the following PR, #18 in this PR.