Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more search results #6

Open
dann-merlin opened this issue Jan 22, 2021 · 2 comments
Open

more search results #6

dann-merlin opened this issue Jan 22, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@dann-merlin
Copy link
Owner

Add a button to every search category, to list more search results. This could be for example a +10 or something so, another max 10 entries are loaded. The button should disappear, when there are no more search results left.

@dann-merlin dann-merlin added the enhancement New feature or request label Jan 22, 2021
@Pacman99
Copy link

This might be harder to write, but wouldn't it be better if a new page opened when you hit more? I think there could be a generic gtk template for a search results page and each type of search(tracks, albums, ...) can just use that to display a separate page for just that type. I think this is how the spotify mobile app does it too.

@dann-merlin
Copy link
Owner Author

Yeah, an entire new page is a good idea.
It also shouldn't be too hard to implement either. I already implemented the ContentDeck to basically work like that.
I had in mind, that one should be able to click on for example an album, when looking at an artist and it should open the album page above the artist page, but then one should be able to go back again with the back button. Pretty much like the mobile app. So you can simply push a "search_artists" page when clicking on a "more artists" button on the search_deck. And it should work like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants