Add entity escaping to URLs

danog · May 7, 2024 · 73dd842 · 73dd842
1 parent d70207f
commit 73dd842
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/Entities.php b/src/Entities.php
@@ -376,7 +376,7 @@ public function toHTML(bool $allowTelegramTags = false): string
                 'italic' => '<i>',
                 'code' => '<code>',
                 'pre' => isset($entity['language']) && $entity['language'] !== '' ? '<pre language="'.$entity['language'].'">' : '<pre>',
-                'text_link' => '<a href="'.$entity['url'].'">',
+                'text_link' => '<a href="'.EntityTools::htmlEscape($entity['url']).'">',
                 'strikethrough' => '<s>',
                 "underline" => '<u>',
                 "block_quote" => '<blockquote>',

diff --git a/tests/EntitiesTest.php b/tests/EntitiesTest.php
@@ -293,6 +293,18 @@ public static function provideHtmlEntities(): iterable
             ]]
         ];
 
+        yield [
+            'test',
+            '<a href="https://google.com/?arg=a&amp;arg2=b">test</a>',
+            '<a href="https://google.com/?arg=a&amp;arg2=b">test</a>',
+            [[
+                'type' => 'text_link',
+                'offset' => 0,
+                'length' => 4,
+                'url' => 'https://google.com/?arg=a&arg2=b',
+            ]]
+        ];
+
         yield [
             'test',
             '<u>test</u>',
@@ -787,17 +799,17 @@ private function provideEntities(): array
             ],
             [
                 'html',
-                '<a href="https://google.com/">link </a>',
+                '<a href="https://google.com/?a=a&amp;b=b">link </a>',
                 'link',
                 [
                     [
                         'offset' => 0,
                         'length' => 4,
                         'type' => 'text_link',
-                        'url' => 'https://google.com/',
+                        'url' => 'https://google.com/?a=a&b=b',
                     ],
                 ],
-                '<a href="https://google.com/">link</a> ',
+                '<a href="https://google.com/?a=a&amp;b=b">link</a> ',
             ],
             [
                 'markdown',