Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some register #38

Closed
wants to merge 7 commits into from
Closed

Added some register #38

wants to merge 7 commits into from

Conversation

Basti-RX
Copy link

No description provided.

@daolis
Copy link
Owner

daolis commented Feb 19, 2024

Hi @Basti-RX,
Thanks for adding the new states.
I only added one comment about the roles. There is a link to the iobrokers dev documentation page about State roles.

Thanks

@@ -126,6 +126,21 @@ export class InverterStates {
state: {id: 'dailyEnergyYield', name: 'Daily energy yield', type: 'number', unit: 'kWh', role: 'value.energy'},
register: {reg: 32114, type: ModbusDatatype.uint32, length: 2, gain: 100}
},
{
interval: UpdateIntervalID.LOW,
state: {id: 'generatedenergytoday', name: 'Daily generated Energy', type: 'number', unit: 'kWh', role: 'value.energy.generated'},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Basti-RX Basti-RX requested a review from daolis February 19, 2024 10:05
@Basti-RX
Copy link
Author

Changed the roles. I hope it will fit now.

// MPPT
{
interval: UpdateIntervalID.LOW,
state: {id: 'mppt1power', name: 'MPPT 1 Power', type: 'number', unit: 'kWh', role: 'value.power.active', desc: 'Total input power of MPPT1'},
Copy link
Owner

@daolis daolis Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Power should be kW ... or
kWh should be energy 😉
(see site roles list)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is changed. Dont know what value will be shown, so further changes will be possible

@Basti-RX Basti-RX requested a review from daolis February 19, 2024 10:21
@@ -126,6 +126,21 @@ export class InverterStates {
state: {id: 'dailyEnergyYield', name: 'Daily energy yield', type: 'number', unit: 'kWh', role: 'value.energy'},
register: {reg: 32114, type: ModbusDatatype.uint32, length: 2, gain: 100}
},
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reg 32114 is already there... see line 127

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See it. Wonder why

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Der 32114 scheint bei mir, habe einen Akku, den Wert wieder zu spiegeln was ich heute benutzt habe und nicht der gesamte ertrag

{
interval: UpdateIntervalID.LOW,
state: {id: 'generatedenergymonth', name: 'Monthly generated Energy', type: 'number', unit: 'kWh', role: 'value.energy.produced'},
register: {reg: 32116, type: ModbusDatatype.uint32, length: 2, gain: 100},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, i did not have these registers in my ModbusInterfaceDefinition document.
@Basti-RX Where do you got it from?
Can you send me the link to the doc?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it help you? Which Version you got?

@Basti-RX
Copy link
Author

Aufgrund Anfrage:
#34 (comment)

Noch die Register
37780 Batterie Total Charge
37782 Batterie Total Discharge
Bei Storage beigefügt.

@Basti-RX Basti-RX requested a review from daolis February 20, 2024 10:09
@Basti-RX Basti-RX closed this Feb 22, 2024
@daolis
Copy link
Owner

daolis commented Feb 27, 2024

Hi @Basti-RX,
Sorry, hatte nicht sehr viel Zeit...
Was war der Grund dass du den PR geschlossen hast?

@Basti-RX
Copy link
Author

Kein Bedarf mehr hier bei dem Adapter weiter zu machen. Der Andere der Verfügbar ist, ist um einiges weiter und besser wie der hier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants