Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grill Comment Integration #136

Merged
merged 19 commits into from
Sep 11, 2023
Merged

Grill Comment Integration #136

merged 19 commits into from
Sep 11, 2023

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Sep 4, 2023

Before Merge

  • Change the hubId to use the real space for comments

.github/workflows/build-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/feature-based.yaml Outdated Show resolved Hide resolved
onUnreadCountChange?: (count: number) => void
}

const COMMENTS_HUB_ID = '1032'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract it to config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, moved it into
common config with name commentsHubId

rootFontSize: '1rem',
channel: {
type: 'resource',
resource: new Resource({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Alex about Resource type, maybe it should be "subsocial" chain instead polkaverse app

@olehmell olehmell merged commit e8854f4 into main Sep 11, 2023
2 checks passed
@olehmell olehmell deleted the deploy/grill-integration branch September 11, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants