Address feedback

Signed-off-by: joshvanl <me@joshvanl.dev>
dapr · Oct 27, 2023 · df5a6c0 · df5a6c0
1 parent ea9999b
commit df5a6c0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/src/Dapr.Actors/Communication/ActorStateResponse.cs b/src/Dapr.Actors/Communication/ActorStateResponse.cs
@@ -18,7 +18,7 @@ namespace Dapr.Actors.Communication
     /// <summary>
     /// Represents a response from fetching an actor state key.
     /// </summary>
-    internal class ActorStateResponse<T>
+    class ActorStateResponse<T>
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="ActorStateResponse{T}"/> class.

diff --git a/src/Dapr.Actors/Runtime/ActorStateManager.cs b/src/Dapr.Actors/Runtime/ActorStateManager.cs
@@ -145,7 +145,7 @@ public async Task<ConditionalValue<T>> TryGetStateAsync<T>(string stateName, Can
                 var stateMetadata = stateChangeTracker[stateName];
 
                 // Check if the property was marked as remove in the cache or is expired
-                if (stateMetadata.ChangeKind == StateChangeKind.Remove || stateMetadata.TTLExpireTime <= DateTime.UtcNow)
+                if (stateMetadata.ChangeKind == StateChangeKind.Remove || stateMetadata.TTLExpireTime <= DateTimeOffset.UtcNow)
                 {
                     return new ConditionalValue<T>(false, default);
                 }
@@ -539,7 +539,7 @@ private StateMetadata(object value, Type type, StateChangeKind changeKind, DateT
                     throw new ArgumentException("Cannot specify both TTLExpireTime and TTL");
                 }
                 if (ttl.HasValue) {
-                    this.TTLExpireTime = DateTime.UtcNow.Add(ttl.Value);
+                    this.TTLExpireTime = DateTimeOffset.UtcNow.Add(ttl.Value);
                 } else {
                     this.TTLExpireTime = ttlExpireTime;
                 }
@@ -553,9 +553,19 @@ private StateMetadata(object value, Type type, StateChangeKind changeKind, DateT
 
             public DateTimeOffset? TTLExpireTime { get; set; }
 
-            public static StateMetadata Create<T>(T value, StateChangeKind changeKind, DateTimeOffset? ttlExpireTime = null, TimeSpan? ttl = null)
+            public static StateMetadata Create<T>(T value, StateChangeKind changeKind)
             {
-                return new StateMetadata(value, typeof(T), changeKind, ttlExpireTime, ttl);
+                return new StateMetadata(value, typeof(T), changeKind);
+            }
+
+            public static StateMetadata Create<T>(T value, StateChangeKind changeKind, DateTimeOffset? ttlExpireTime)
+            {
+                return new StateMetadata(value, typeof(T), changeKind, ttlExpireTime: ttlExpireTime);
+            }
+
+            public static StateMetadata Create<T>(T value, StateChangeKind changeKind, TimeSpan? ttl)
+            {
+                return new StateMetadata(value, typeof(T), changeKind, ttl: ttl);
             }
 
             public static StateMetadata CreateForRemove()

diff --git a/src/Dapr.Actors/Runtime/DaprStateProvider.cs b/src/Dapr.Actors/Runtime/DaprStateProvider.cs
@@ -49,7 +49,7 @@ public async Task<ConditionalValue<ActorStateResponse<T>>> TryLoadStateAsync<T>(
             var result = new ConditionalValue<ActorStateResponse<T>>(false, default);
             var response = await this.daprInteractor.GetStateAsync(actorType, actorId, stateName, cancellationToken);
 
-            if (response.Value.Length != 0 && response.TTLExpireTime > DateTime.UtcNow)
+            if (response.Value.Length != 0 && response.TTLExpireTime > DateTimeOffset.UtcNow)
             {
                 T typedResult;
 
@@ -135,7 +135,7 @@ private async Task DoStateChangesTransactionallyAsync(string actorType, string a
                         }
 
                         if (stateChange.TTLExpireTime.HasValue) {
-                            var ttl = (int)Math.Ceiling((stateChange.TTLExpireTime.Value - DateTime.UtcNow).TotalSeconds);
+                            var ttl = (int)Math.Ceiling((stateChange.TTLExpireTime.Value - DateTimeOffset.UtcNow).TotalSeconds);
                             writer.WriteString("ttlInSeconds", ttl.ToString());
                         }