Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .NET Core 3.1 support and standardize on .NET 6 #1045

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

yash-nisar
Copy link
Contributor

Description

Remove .NET Core 3.1 support and standardize on .NET 6

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1036

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@yash-nisar yash-nisar requested review from a team as code owners February 27, 2023 15:23
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1045 (0cbf380) into master (667dcaf) will decrease coverage by 0.10%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   67.12%   67.02%   -0.10%     
==========================================
  Files         170      170              
  Lines        5698     5693       -5     
  Branches      607      607              
==========================================
- Hits         3825     3816       -9     
- Misses       1730     1732       +2     
- Partials      143      145       +2     
Flag Coverage Δ
net6 67.02% <78.57%> (-0.03%) ⬇️
net7 67.02% <78.57%> (-0.03%) ⬇️
netcoreapp3.1 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Dapr.Actors/Communication/ActorInvokeException.cs 59.09% <0.00%> (ø)
src/Dapr.Client/InvocationHandler.cs 89.18% <ø> (ø)
src/Dapr.Client/DaprClientGrpc.cs 73.90% <84.61%> (-0.16%) ⬇️

... and 2 files with indirect coverage changes

@halspang
Copy link
Contributor

@yash-nisar - Thanks for taking the initiative here, but we can't remove this without communicating it first. We need to establish a pattern that we're going to follow in the repo, which, in my opinion, should just be following Microsoft's lifetime guidance.

So, we should do this, but we need to find a way to communicate it to the community first to give people time to prepare. Then we can go ahead and do this.

@cgillum
Copy link
Contributor

cgillum commented Mar 14, 2023

@halspang how can we move forward with this? Microsoft has already announced that .NET Core 3.1 is no longer supported.

https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/

In addition to Microsoft's communication, does there need to be a proposal in a Dapr community forum? I'd like to move this forward, if possible, to reduce support burden and test matrix.

test/Dapr.E2E.Test/DaprTestApp.cs Outdated Show resolved Hide resolved
.github/workflows/itests.yml Outdated Show resolved Hide resolved
.github/workflows/sdk_build.yml Show resolved Hide resolved
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
@halspang halspang merged commit 17f849b into dapr:master Aug 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .NET Core 3.1 support and standardize on .NET 6
3 participants