From 6e8f40634de8aa0fc25ec6de898f72df22c059d1 Mon Sep 17 00:00:00 2001 From: Yash Nisar Date: Mon, 27 Feb 2023 05:37:00 -0600 Subject: [PATCH 1/2] Remove .NET Core 3.1 support and standardize on .NET 6 Signed-off-by: Yash Nisar --- .github/workflows/itests.yml | 8 +---- .github/workflows/sdk_build.yml | 8 +---- examples/Actor/ActorClient/ActorClient.csproj | 2 +- examples/Actor/DemoActor/DemoActor.csproj | 2 +- examples/Actor/IDemoActor/IDemoActor.csproj | 2 +- .../ControllerSample/ControllerSample.csproj | 2 +- .../AspNetCore/ControllerSample/README.md | 2 +- .../GrpcServiceSample.csproj | 2 +- .../AspNetCore/GrpcServiceSample/README.md | 2 +- examples/AspNetCore/RoutingSample/README.md | 2 +- .../README.md | 2 +- ...retStoreConfigurationProviderSample.csproj | 2 +- .../ConfigurationApi/ConfigurationApi.csproj | 2 +- examples/Client/ConfigurationApi/README.md | 2 +- .../DistributedLock/DistributedLock.csproj | 2 +- examples/Client/DistributedLock/README.md | 2 +- .../BulkPublishEventExample.csproj | 2 +- .../PublishEventExample.csproj | 2 +- examples/Client/ServiceInvocation/README.md | 2 +- .../ServiceInvocation.csproj | 2 +- examples/Client/StateManagement/README.md | 2 +- .../StateManagement/StateManagement.csproj | 2 +- properties/IsExternalInit.cs | 3 +- .../Dapr.Actors.AspNetCore.csproj | 2 +- .../Communication/ActorInvokeException.cs | 2 +- src/Dapr.Actors/Dapr.Actors.csproj | 2 +- src/Dapr.AspNetCore/Dapr.AspNetCore.csproj | 2 +- src/Dapr.Client/Dapr.Client.csproj | 2 +- src/Dapr.Client/DaprClientGrpc.cs | 32 ++++++++----------- src/Dapr.Client/InvocationHandler.cs | 2 +- .../Dapr.Extensions.Configuration.csproj | 2 +- src/Dapr.Workflow/Dapr.Workflow.csproj | 2 +- ...tors.AspNetCore.IntegrationTest.App.csproj | 2 +- ...r.Actors.AspNetCore.IntegrationTest.csproj | 2 +- .../Dapr.Actors.AspNetCore.Test.csproj | 2 +- test/Dapr.Actors.Test/Dapr.Actors.Test.csproj | 2 +- ...Dapr.AspNetCore.IntegrationTest.App.csproj | 2 +- .../Dapr.AspNetCore.IntegrationTest.csproj | 2 +- .../Dapr.AspNetCore.Test.csproj | 2 +- test/Dapr.Client.Test/Dapr.Client.Test.csproj | 2 +- .../Dapr.E2E.Test.Actors.csproj | 2 +- .../Dapr.E2E.Test.App.Grpc.csproj | 2 +- .../Dapr.E2E.Test.App.ReentrantActors.csproj | 2 +- .../Dapr.E2E.Test.App.csproj | 2 +- test/Dapr.E2E.Test/Dapr.E2E.Test.csproj | 2 +- test/Dapr.E2E.Test/DaprTestApp.cs | 6 +--- .../Dapr.Extensions.Configuration.Test.csproj | 2 +- 47 files changed, 60 insertions(+), 81 deletions(-) diff --git a/.github/workflows/itests.yml b/.github/workflows/itests.yml index 3f42b6bd2..e5305c7b2 100644 --- a/.github/workflows/itests.yml +++ b/.github/workflows/itests.yml @@ -19,14 +19,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - dotnet-version: ['3.1', '6.0', '7.0'] + dotnet-version: ['6.0', '7.0'] include: - - dotnet-version: '3.1' - install-3: true - display-name: '.NET Core 3.1' - framework: 'netcoreapp3.1' - prefix: 'netcoreapp31' - install-version: '3.1.x' # We always need a new .NET - dotnet-version: '6.0' install-3: false display-name: '.NET 6.0' diff --git a/.github/workflows/sdk_build.yml b/.github/workflows/sdk_build.yml index b0b6b042c..1c4e1a60e 100644 --- a/.github/workflows/sdk_build.yml +++ b/.github/workflows/sdk_build.yml @@ -42,14 +42,8 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - dotnet-version: ['3.1', '6.0', '7.0'] + dotnet-version: ['6.0', '7.0'] include: - - dotnet-version: '3.1' - install-3: true - display-name: '.NET Core 3.1' - framework: 'netcoreapp3.1' - prefix: 'netcoreapp31' - install-version: '3.1.x' # We always need a new .NET - dotnet-version: '6.0' install-3: false display-name: '.NET 6.0' diff --git a/examples/Actor/ActorClient/ActorClient.csproj b/examples/Actor/ActorClient/ActorClient.csproj index 48c8318c6..0d1d94f55 100644 --- a/examples/Actor/ActorClient/ActorClient.csproj +++ b/examples/Actor/ActorClient/ActorClient.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 diff --git a/examples/Actor/DemoActor/DemoActor.csproj b/examples/Actor/DemoActor/DemoActor.csproj index 80a3883c3..1ee37fdbe 100644 --- a/examples/Actor/DemoActor/DemoActor.csproj +++ b/examples/Actor/DemoActor/DemoActor.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/examples/Actor/IDemoActor/IDemoActor.csproj b/examples/Actor/IDemoActor/IDemoActor.csproj index 23a96ffc6..9f7744796 100644 --- a/examples/Actor/IDemoActor/IDemoActor.csproj +++ b/examples/Actor/IDemoActor/IDemoActor.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/examples/AspNetCore/ControllerSample/ControllerSample.csproj b/examples/AspNetCore/ControllerSample/ControllerSample.csproj index 863290324..6dbe750a6 100644 --- a/examples/AspNetCore/ControllerSample/ControllerSample.csproj +++ b/examples/AspNetCore/ControllerSample/ControllerSample.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/examples/AspNetCore/ControllerSample/README.md b/examples/AspNetCore/ControllerSample/README.md index a2700e94d..3b2ca02b9 100644 --- a/examples/AspNetCore/ControllerSample/README.md +++ b/examples/AspNetCore/ControllerSample/README.md @@ -12,7 +12,7 @@ The application also registers for pub/sub with the `deposit`, `multideposit` an ## Prerequisitess -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/AspNetCore/GrpcServiceSample/GrpcServiceSample.csproj b/examples/AspNetCore/GrpcServiceSample/GrpcServiceSample.csproj index 5ce78bc57..123763489 100644 --- a/examples/AspNetCore/GrpcServiceSample/GrpcServiceSample.csproj +++ b/examples/AspNetCore/GrpcServiceSample/GrpcServiceSample.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1 + net6 true diff --git a/examples/AspNetCore/GrpcServiceSample/README.md b/examples/AspNetCore/GrpcServiceSample/README.md index 3f27d280c..d08e96cd9 100644 --- a/examples/AspNetCore/GrpcServiceSample/README.md +++ b/examples/AspNetCore/GrpcServiceSample/README.md @@ -11,7 +11,7 @@ The application also registers for pub/sub with the `deposit` and `withdraw` top ## Prerequisitess -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/AspNetCore/RoutingSample/README.md b/examples/AspNetCore/RoutingSample/README.md index cd545b747..901c51c40 100644 --- a/examples/AspNetCore/RoutingSample/README.md +++ b/examples/AspNetCore/RoutingSample/README.md @@ -12,7 +12,7 @@ The application also registers for pub/sub with the `deposit`, `multideposit`, a ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/AspNetCore/SecretStoreConfigurationProviderSample/README.md b/examples/AspNetCore/SecretStoreConfigurationProviderSample/README.md index 5be9eb5e1..09422e474 100644 --- a/examples/AspNetCore/SecretStoreConfigurationProviderSample/README.md +++ b/examples/AspNetCore/SecretStoreConfigurationProviderSample/README.md @@ -2,7 +2,7 @@ ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/AspNetCore/SecretStoreConfigurationProviderSample/SecretStoreConfigurationProviderSample.csproj b/examples/AspNetCore/SecretStoreConfigurationProviderSample/SecretStoreConfigurationProviderSample.csproj index 10928470b..01fbc2079 100644 --- a/examples/AspNetCore/SecretStoreConfigurationProviderSample/SecretStoreConfigurationProviderSample.csproj +++ b/examples/AspNetCore/SecretStoreConfigurationProviderSample/SecretStoreConfigurationProviderSample.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 diff --git a/examples/Client/ConfigurationApi/ConfigurationApi.csproj b/examples/Client/ConfigurationApi/ConfigurationApi.csproj index f73fd4974..dee6a9878 100644 --- a/examples/Client/ConfigurationApi/ConfigurationApi.csproj +++ b/examples/Client/ConfigurationApi/ConfigurationApi.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1 + net6 diff --git a/examples/Client/ConfigurationApi/README.md b/examples/Client/ConfigurationApi/README.md index 41c1c831f..7425a780a 100644 --- a/examples/Client/ConfigurationApi/README.md +++ b/examples/Client/ConfigurationApi/README.md @@ -9,7 +9,7 @@ It demonstrates the following APIs: ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/Client/DistributedLock/DistributedLock.csproj b/examples/Client/DistributedLock/DistributedLock.csproj index 180c46f28..9c3272e6e 100644 --- a/examples/Client/DistributedLock/DistributedLock.csproj +++ b/examples/Client/DistributedLock/DistributedLock.csproj @@ -6,7 +6,7 @@ - netcoreapp3.1 + net6 diff --git a/examples/Client/DistributedLock/README.md b/examples/Client/DistributedLock/README.md index 788d57e3a..cdac6f91a 100644 --- a/examples/Client/DistributedLock/README.md +++ b/examples/Client/DistributedLock/README.md @@ -2,7 +2,7 @@ ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/Client/PublishSubscribe/BulkPublishEventExample/BulkPublishEventExample.csproj b/examples/Client/PublishSubscribe/BulkPublishEventExample/BulkPublishEventExample.csproj index 5c05faf9f..3f22acaf8 100644 --- a/examples/Client/PublishSubscribe/BulkPublishEventExample/BulkPublishEventExample.csproj +++ b/examples/Client/PublishSubscribe/BulkPublishEventExample/BulkPublishEventExample.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 Samples.Client enable diff --git a/examples/Client/PublishSubscribe/PublishEventExample/PublishEventExample.csproj b/examples/Client/PublishSubscribe/PublishEventExample/PublishEventExample.csproj index f7d335879..2df4ec967 100644 --- a/examples/Client/PublishSubscribe/PublishEventExample/PublishEventExample.csproj +++ b/examples/Client/PublishSubscribe/PublishEventExample/PublishEventExample.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 Samples.Client enable diff --git a/examples/Client/ServiceInvocation/README.md b/examples/Client/ServiceInvocation/README.md index 171869c15..ede5a506a 100644 --- a/examples/Client/ServiceInvocation/README.md +++ b/examples/Client/ServiceInvocation/README.md @@ -2,7 +2,7 @@ ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/Client/ServiceInvocation/ServiceInvocation.csproj b/examples/Client/ServiceInvocation/ServiceInvocation.csproj index 790bfc53a..e3df962a1 100644 --- a/examples/Client/ServiceInvocation/ServiceInvocation.csproj +++ b/examples/Client/ServiceInvocation/ServiceInvocation.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 Samples.Client enable diff --git a/examples/Client/StateManagement/README.md b/examples/Client/StateManagement/README.md index 141f16760..fb266a242 100644 --- a/examples/Client/StateManagement/README.md +++ b/examples/Client/StateManagement/README.md @@ -2,7 +2,7 @@ ## Prerequisites -- [.NET Core 3.1 or .NET 5+](https://dotnet.microsoft.com/download) installed +- [.NET 6+](https://dotnet.microsoft.com/download) installed - [Dapr CLI](https://docs.dapr.io/getting-started/install-dapr-cli/) - [Initialized Dapr environment](https://docs.dapr.io/getting-started/install-dapr-selfhost/) - [Dapr .NET SDK](https://docs.dapr.io/developing-applications/sdks/dotnet/) diff --git a/examples/Client/StateManagement/StateManagement.csproj b/examples/Client/StateManagement/StateManagement.csproj index 790bfc53a..e3df962a1 100644 --- a/examples/Client/StateManagement/StateManagement.csproj +++ b/examples/Client/StateManagement/StateManagement.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1 + net6 Samples.Client enable diff --git a/properties/IsExternalInit.cs b/properties/IsExternalInit.cs index 2f68a08f4..34357c39a 100644 --- a/properties/IsExternalInit.cs +++ b/properties/IsExternalInit.cs @@ -13,6 +13,5 @@ namespace System.Runtime.CompilerServices internal static class IsExternalInit { } - - // This is a polyfill for init only properties in netcoreapp3.1 + } diff --git a/src/Dapr.Actors.AspNetCore/Dapr.Actors.AspNetCore.csproj b/src/Dapr.Actors.AspNetCore/Dapr.Actors.AspNetCore.csproj index a9f6e8818..cfd7d8123 100644 --- a/src/Dapr.Actors.AspNetCore/Dapr.Actors.AspNetCore.csproj +++ b/src/Dapr.Actors.AspNetCore/Dapr.Actors.AspNetCore.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1 + net6 diff --git a/src/Dapr.Actors/Communication/ActorInvokeException.cs b/src/Dapr.Actors/Communication/ActorInvokeException.cs index ed17a7f55..ac4ea63df 100644 --- a/src/Dapr.Actors/Communication/ActorInvokeException.cs +++ b/src/Dapr.Actors/Communication/ActorInvokeException.cs @@ -93,7 +93,7 @@ internal static bool TryDeserialize(Stream stream, out Exception result, ILogger catch (Exception e) { // swallowing the exception - logger?.LogWarning("RemoteException", "DeSerialization failed : Reason {0}", e); + logger?.LogWarning("RemoteException: DeSerialization failed : Reason {0}", e); } result = null; diff --git a/src/Dapr.Actors/Dapr.Actors.csproj b/src/Dapr.Actors/Dapr.Actors.csproj index 1c0e0bdfb..f2ac963df 100644 --- a/src/Dapr.Actors/Dapr.Actors.csproj +++ b/src/Dapr.Actors/Dapr.Actors.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/src/Dapr.AspNetCore/Dapr.AspNetCore.csproj b/src/Dapr.AspNetCore/Dapr.AspNetCore.csproj index c119b2d3e..a50133677 100644 --- a/src/Dapr.AspNetCore/Dapr.AspNetCore.csproj +++ b/src/Dapr.AspNetCore/Dapr.AspNetCore.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/src/Dapr.Client/Dapr.Client.csproj b/src/Dapr.Client/Dapr.Client.csproj index 59a38a3e4..45dd168fe 100644 --- a/src/Dapr.Client/Dapr.Client.csproj +++ b/src/Dapr.Client/Dapr.Client.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1 + net6 diff --git a/src/Dapr.Client/DaprClientGrpc.cs b/src/Dapr.Client/DaprClientGrpc.cs index c1cad41e1..79f7f59ae 100644 --- a/src/Dapr.Client/DaprClientGrpc.cs +++ b/src/Dapr.Client/DaprClientGrpc.cs @@ -352,14 +352,10 @@ public override HttpRequestMessage CreateInvokeMethodRequest(HttpMethod httpMeth // // This approach avoids some common pitfalls that could lead to undesired encoding. var path = $"/v1.0/invoke/{appId}/method/{methodName.TrimStart('/')}"; - var request = new HttpRequestMessage(httpMethod, new Uri(this.httpEndpoint, path)) - { - Properties = - { - { AppIdKey, appId }, - { MethodNameKey, methodName }, - } - }; + var request = new HttpRequestMessage(httpMethod, new Uri(this.httpEndpoint, path)); + + request.Options.Set(new HttpRequestOptionsKey(AppIdKey), appId); + request.Options.Set(new HttpRequestOptionsKey(MethodNameKey), methodName); if (this.apiTokenHeader is not null) { @@ -399,8 +395,8 @@ public override async Task InvokeMethodWithResponseAsync(Ht { // Our code path for creating requests places these keys in the request properties. We don't want to fail // if they are not present. - request.Properties.TryGetValue(AppIdKey, out var appId); - request.Properties.TryGetValue(MethodNameKey, out var methodName); + request.Options.TryGetValue(new HttpRequestOptionsKey(AppIdKey), out var appId); + request.Options.TryGetValue(new HttpRequestOptionsKey(MethodNameKey), out var methodName); throw new InvocationException( appId: appId as string, @@ -423,8 +419,8 @@ public async override Task InvokeMethodAsync(HttpRequestMessage request, Cancell { // Our code path for creating requests places these keys in the request properties. We don't want to fail // if they are not present. - request.Properties.TryGetValue(AppIdKey, out var appId); - request.Properties.TryGetValue(MethodNameKey, out var methodName); + request.Options.TryGetValue(new HttpRequestOptionsKey(AppIdKey), out var appId); + request.Options.TryGetValue(new HttpRequestOptionsKey(MethodNameKey), out var methodName); throw new InvocationException( appId: appId as string, @@ -447,8 +443,8 @@ public async override Task InvokeMethodAsync(HttpRequestMe { // Our code path for creating requests places these keys in the request properties. We don't want to fail // if they are not present. - request.Properties.TryGetValue(AppIdKey, out var appId); - request.Properties.TryGetValue(MethodNameKey, out var methodName); + request.Options.TryGetValue(new HttpRequestOptionsKey(AppIdKey), out var appId); + request.Options.TryGetValue(new HttpRequestOptionsKey(MethodNameKey), out var methodName); throw new InvocationException( appId: appId as string, @@ -465,8 +461,8 @@ public async override Task InvokeMethodAsync(HttpRequestMe { // Our code path for creating requests places these keys in the request properties. We don't want to fail // if they are not present. - request.Properties.TryGetValue(AppIdKey, out var appId); - request.Properties.TryGetValue(MethodNameKey, out var methodName); + request.Options.TryGetValue(new HttpRequestOptionsKey(AppIdKey), out var appId); + request.Options.TryGetValue(new HttpRequestOptionsKey(MethodNameKey), out var methodName); throw new InvocationException( appId: appId as string, @@ -476,8 +472,8 @@ public async override Task InvokeMethodAsync(HttpRequestMe } catch (JsonException ex) { - request.Properties.TryGetValue(AppIdKey, out var appId); - request.Properties.TryGetValue(MethodNameKey, out var methodName); + request.Options.TryGetValue(new HttpRequestOptionsKey(AppIdKey), out var appId); + request.Options.TryGetValue(new HttpRequestOptionsKey(MethodNameKey), out var methodName); throw new InvocationException( appId: appId as string, diff --git a/src/Dapr.Client/InvocationHandler.cs b/src/Dapr.Client/InvocationHandler.cs index b2f74c7f9..1e9000c4d 100644 --- a/src/Dapr.Client/InvocationHandler.cs +++ b/src/Dapr.Client/InvocationHandler.cs @@ -117,7 +117,7 @@ protected override async Task SendAsync(HttpRequestMessage } // Internal for testing - internal bool TryRewriteUri(Uri uri, [NotNullWhen(true)] out Uri? rewritten) + internal bool TryRewriteUri(Uri? uri, [NotNullWhen(true)] out Uri? rewritten) { // For now the only invalid cases are when the request URI is missing or just silly. // We may support additional cases for validation in the future (like an allow-list of App-Ids). diff --git a/src/Dapr.Extensions.Configuration/Dapr.Extensions.Configuration.csproj b/src/Dapr.Extensions.Configuration/Dapr.Extensions.Configuration.csproj index 7eec7f4f7..0f1f64048 100644 --- a/src/Dapr.Extensions.Configuration/Dapr.Extensions.Configuration.csproj +++ b/src/Dapr.Extensions.Configuration/Dapr.Extensions.Configuration.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1 + net6 enable diff --git a/src/Dapr.Workflow/Dapr.Workflow.csproj b/src/Dapr.Workflow/Dapr.Workflow.csproj index f6c28b02f..781e891d0 100644 --- a/src/Dapr.Workflow/Dapr.Workflow.csproj +++ b/src/Dapr.Workflow/Dapr.Workflow.csproj @@ -2,7 +2,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 enable Dapr.Workflow Dapr Workflow Authoring SDK diff --git a/test/Dapr.Actors.AspNetCore.IntegrationTest.App/Dapr.Actors.AspNetCore.IntegrationTest.App.csproj b/test/Dapr.Actors.AspNetCore.IntegrationTest.App/Dapr.Actors.AspNetCore.IntegrationTest.App.csproj index a518db3f5..af0bfa13e 100644 --- a/test/Dapr.Actors.AspNetCore.IntegrationTest.App/Dapr.Actors.AspNetCore.IntegrationTest.App.csproj +++ b/test/Dapr.Actors.AspNetCore.IntegrationTest.App/Dapr.Actors.AspNetCore.IntegrationTest.App.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.Actors.AspNetCore.IntegrationTest/Dapr.Actors.AspNetCore.IntegrationTest.csproj b/test/Dapr.Actors.AspNetCore.IntegrationTest/Dapr.Actors.AspNetCore.IntegrationTest.csproj index 0f2d6b580..1b8590d7e 100644 --- a/test/Dapr.Actors.AspNetCore.IntegrationTest/Dapr.Actors.AspNetCore.IntegrationTest.csproj +++ b/test/Dapr.Actors.AspNetCore.IntegrationTest/Dapr.Actors.AspNetCore.IntegrationTest.csproj @@ -1,6 +1,6 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.Actors.AspNetCore.Test/Dapr.Actors.AspNetCore.Test.csproj b/test/Dapr.Actors.AspNetCore.Test/Dapr.Actors.AspNetCore.Test.csproj index 071b72746..962963ac2 100644 --- a/test/Dapr.Actors.AspNetCore.Test/Dapr.Actors.AspNetCore.Test.csproj +++ b/test/Dapr.Actors.AspNetCore.Test/Dapr.Actors.AspNetCore.Test.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 Dapr.Actors.AspNetCore diff --git a/test/Dapr.Actors.Test/Dapr.Actors.Test.csproj b/test/Dapr.Actors.Test/Dapr.Actors.Test.csproj index 0ac27e077..8a0fa16d7 100644 --- a/test/Dapr.Actors.Test/Dapr.Actors.Test.csproj +++ b/test/Dapr.Actors.Test/Dapr.Actors.Test.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 Dapr.Actors $(DefineConstants);ACTORS diff --git a/test/Dapr.AspNetCore.IntegrationTest.App/Dapr.AspNetCore.IntegrationTest.App.csproj b/test/Dapr.AspNetCore.IntegrationTest.App/Dapr.AspNetCore.IntegrationTest.App.csproj index 86a561f59..0e15b6855 100644 --- a/test/Dapr.AspNetCore.IntegrationTest.App/Dapr.AspNetCore.IntegrationTest.App.csproj +++ b/test/Dapr.AspNetCore.IntegrationTest.App/Dapr.AspNetCore.IntegrationTest.App.csproj @@ -1,7 +1,7 @@  - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.AspNetCore.IntegrationTest/Dapr.AspNetCore.IntegrationTest.csproj b/test/Dapr.AspNetCore.IntegrationTest/Dapr.AspNetCore.IntegrationTest.csproj index f3c08b1b7..c3cfd2cbf 100644 --- a/test/Dapr.AspNetCore.IntegrationTest/Dapr.AspNetCore.IntegrationTest.csproj +++ b/test/Dapr.AspNetCore.IntegrationTest/Dapr.AspNetCore.IntegrationTest.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.AspNetCore.Test/Dapr.AspNetCore.Test.csproj b/test/Dapr.AspNetCore.Test/Dapr.AspNetCore.Test.csproj index b153287b2..27f11a308 100644 --- a/test/Dapr.AspNetCore.Test/Dapr.AspNetCore.Test.csproj +++ b/test/Dapr.AspNetCore.Test/Dapr.AspNetCore.Test.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.Client.Test/Dapr.Client.Test.csproj b/test/Dapr.Client.Test/Dapr.Client.Test.csproj index 36f9e725b..c6de11e31 100644 --- a/test/Dapr.Client.Test/Dapr.Client.Test.csproj +++ b/test/Dapr.Client.Test/Dapr.Client.Test.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test.Actors/Dapr.E2E.Test.Actors.csproj b/test/Dapr.E2E.Test.Actors/Dapr.E2E.Test.Actors.csproj index a0f13978d..0455d6db4 100644 --- a/test/Dapr.E2E.Test.Actors/Dapr.E2E.Test.Actors.csproj +++ b/test/Dapr.E2E.Test.Actors/Dapr.E2E.Test.Actors.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test.App.Grpc/Dapr.E2E.Test.App.Grpc.csproj b/test/Dapr.E2E.Test.App.Grpc/Dapr.E2E.Test.App.Grpc.csproj index abd821d39..8dcf009bc 100644 --- a/test/Dapr.E2E.Test.App.Grpc/Dapr.E2E.Test.App.Grpc.csproj +++ b/test/Dapr.E2E.Test.App.Grpc/Dapr.E2E.Test.App.Grpc.csproj @@ -1,6 +1,6 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test.App.ReentrantActor/Dapr.E2E.Test.App.ReentrantActors.csproj b/test/Dapr.E2E.Test.App.ReentrantActor/Dapr.E2E.Test.App.ReentrantActors.csproj index b533b52f3..dd087aef1 100644 --- a/test/Dapr.E2E.Test.App.ReentrantActor/Dapr.E2E.Test.App.ReentrantActors.csproj +++ b/test/Dapr.E2E.Test.App.ReentrantActor/Dapr.E2E.Test.App.ReentrantActors.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test.App/Dapr.E2E.Test.App.csproj b/test/Dapr.E2E.Test.App/Dapr.E2E.Test.App.csproj index 7e114e8df..30d47e7c2 100644 --- a/test/Dapr.E2E.Test.App/Dapr.E2E.Test.App.csproj +++ b/test/Dapr.E2E.Test.App/Dapr.E2E.Test.App.csproj @@ -1,7 +1,7 @@ - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test/Dapr.E2E.Test.csproj b/test/Dapr.E2E.Test/Dapr.E2E.Test.csproj index 10ae69b38..8b1448759 100644 --- a/test/Dapr.E2E.Test/Dapr.E2E.Test.csproj +++ b/test/Dapr.E2E.Test/Dapr.E2E.Test.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 diff --git a/test/Dapr.E2E.Test/DaprTestApp.cs b/test/Dapr.E2E.Test/DaprTestApp.cs index ee842f27b..0836056f6 100644 --- a/test/Dapr.E2E.Test/DaprTestApp.cs +++ b/test/Dapr.E2E.Test/DaprTestApp.cs @@ -128,11 +128,7 @@ private static string GetTargetFrameworkName() { var targetFrameworkName = ((TargetFrameworkAttribute)Assembly.GetExecutingAssembly().GetCustomAttributes(typeof(TargetFrameworkAttribute), false).FirstOrDefault()).FrameworkName; string frameworkMoniker; - if (targetFrameworkName == ".NETCoreApp,Version=v3.1") - { - frameworkMoniker = "netcoreapp3.1"; - } - else if (targetFrameworkName == ".NETCoreApp,Version=v5.0") + if (targetFrameworkName == ".NETCoreApp,Version=v5.0") { frameworkMoniker = "net5"; } diff --git a/test/Dapr.Extensions.Configuration.Test/Dapr.Extensions.Configuration.Test.csproj b/test/Dapr.Extensions.Configuration.Test/Dapr.Extensions.Configuration.Test.csproj index 79e980ccb..0cd57ca67 100644 --- a/test/Dapr.Extensions.Configuration.Test/Dapr.Extensions.Configuration.Test.csproj +++ b/test/Dapr.Extensions.Configuration.Test/Dapr.Extensions.Configuration.Test.csproj @@ -1,6 +1,6 @@  - netcoreapp3.1;net6;net7 + net6;net7 From 0cbf380890f9ef4b953ea8bbb5bd872c0377cc6b Mon Sep 17 00:00:00 2001 From: Yash Nisar Date: Fri, 18 Aug 2023 12:54:18 -0500 Subject: [PATCH 2/2] Remove support for .NET 5 as well Signed-off-by: Yash Nisar --- .github/workflows/itests.yml | 2 -- test/Dapr.E2E.Test/DaprTestApp.cs | 6 +----- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/itests.yml b/.github/workflows/itests.yml index e5305c7b2..870264f40 100644 --- a/.github/workflows/itests.yml +++ b/.github/workflows/itests.yml @@ -22,13 +22,11 @@ jobs: dotnet-version: ['6.0', '7.0'] include: - dotnet-version: '6.0' - install-3: false display-name: '.NET 6.0' framework: 'net6' prefix: 'net6' install-version: '6.0.x' - dotnet-version: '7.0' - install-3: false display-name: '.NET 7.0' framework: 'net7' prefix: 'net7' diff --git a/test/Dapr.E2E.Test/DaprTestApp.cs b/test/Dapr.E2E.Test/DaprTestApp.cs index 0836056f6..0d89be674 100644 --- a/test/Dapr.E2E.Test/DaprTestApp.cs +++ b/test/Dapr.E2E.Test/DaprTestApp.cs @@ -128,11 +128,7 @@ private static string GetTargetFrameworkName() { var targetFrameworkName = ((TargetFrameworkAttribute)Assembly.GetExecutingAssembly().GetCustomAttributes(typeof(TargetFrameworkAttribute), false).FirstOrDefault()).FrameworkName; string frameworkMoniker; - if (targetFrameworkName == ".NETCoreApp,Version=v5.0") - { - frameworkMoniker = "net5"; - } - else if (targetFrameworkName == ".NETCoreApp,Version=v6.0") + if (targetFrameworkName == ".NETCoreApp,Version=v6.0") { frameworkMoniker = "net6"; }