Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 Support #1188

Merged
merged 4 commits into from
Nov 15, 2023
Merged

.NET 8 Support #1188

merged 4 commits into from
Nov 15, 2023

Conversation

philliphoff
Copy link
Collaborator

Description

Add explicit .NET 8 targets to Dapr .NET SDK NuGet packages.

Currently, the Dapr .NET SDK NuGet packages target only .NET 6 (except for Workflow, which also targets .NET 7). With this change, the packages will additionally target .NET 8.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1187

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Phillip Hoff <phillip@orst.edu>
Signed-off-by: Phillip Hoff <phillip@orst.edu>
Signed-off-by: Phillip Hoff <phillip@orst.edu>
@philliphoff philliphoff requested review from a team as code owners November 14, 2023 19:18
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (39a38f6) 66.42% compared to head (69e1138) 66.53%.

Files Patch % Lines
...AspNetCore/ActorsEndpointRouteBuilderExtensions.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   66.42%   66.53%   +0.10%     
==========================================
  Files         171      171              
  Lines        5758     5752       -6     
  Branches      626      626              
==========================================
+ Hits         3825     3827       +2     
+ Misses       1784     1776       -8     
  Partials      149      149              
Flag Coverage Δ
net6 66.52% <0.00%> (+0.09%) ⬆️
net7 66.52% <0.00%> (+0.09%) ⬆️
net8 66.52% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philliphoff
Copy link
Collaborator Author

I assume codecov/patch is failing to due to the addition of the new .NET 8 target (and its codecoverage results), but I'm not familiar enough with the service to know what needs to change, if anything, to make it pass.

@halspang halspang merged commit 09008bb into dapr:master Nov 15, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET 8
2 participants