Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow sample fanout/fanin #1204

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Dec 8, 2023

Description

Please reference the issue #1203

@MregXN MregXN requested review from a team as code owners December 8, 2023 02:06
@MregXN MregXN marked this pull request as draft December 8, 2023 02:06
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.53%. Comparing base (10ef818) to head (c08017e).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files         171      171           
  Lines        5752     5752           
  Branches      626      626           
=======================================
  Hits         3827     3827           
  Misses       1776     1776           
  Partials      149      149           
Flag Coverage Δ
net6 66.52% <ø> (ø)
net7 66.52% <ø> (ø)
net8 66.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MregXN MregXN force-pushed the add-workflow-sample-fanoutfanin branch from 45e63cf to 7cc3b66 Compare December 8, 2023 12:46
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN force-pushed the add-workflow-sample-fanoutfanin branch from 7cc3b66 to 1578c53 Compare December 9, 2023 09:10
@MregXN MregXN marked this pull request as ready for review December 9, 2023 09:10
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo
Copy link
Contributor

@MregXN First of all, thank you very much for your contributions!

I'd like to merge this and your other PRs, but it looks as though they're using the since-deprecated methods on the DaprClient instead of those from the separate Dapr.Workflow client.

Each client had the same general layout, so I created a matching review on each and suggested a few typo corrections to the README. If you're able to get these changes made, I don't see any other blockers to merging each of these into 1.15 barring a brief review following your updates.

@WhitWaldo WhitWaldo added this to the v1.15 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants