Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused using statements. #1313

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

RafaelJCamara
Copy link
Contributor

Description

Remove unused using statements.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@RafaelJCamara RafaelJCamara requested review from a team as code owners June 22, 2024 12:24
@philliphoff philliphoff added this to the v1.15 milestone Jun 25, 2024
@m3nax
Copy link
Contributor

m3nax commented Jun 26, 2024

@RafaelJCamara Can you sign DCO? It's the only action that fails

git rebase HEAD~1 --signoff
git push --force-with-lease origin remove-usings

Signed-off-by: Rafael Camara <rafaelcamarac@gmail.com>
@RafaelJCamara
Copy link
Contributor Author

@m3nax Done!

@WhitWaldo
Copy link
Contributor

@RafaelJCamara Thank you for your contribution!

I merged the latest from master in your branch and it's showing a number of build/test failures. As you've got the time for it, I'd appreciate it if you could remedy whatever has broken here as a result of the changes. Once it's all passing, please ping me with a notification and I'd be happy to accept and merge your PR.

@RafaelJCamara
Copy link
Contributor Author

@WhitWaldo Merge conflicts solved.

Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for your contribution!

@WhitWaldo WhitWaldo merged commit c61b15d into dapr:master Oct 24, 2024
10 checks passed
@RafaelJCamara RafaelJCamara deleted the remove-usings branch October 24, 2024 22:02
WhitWaldo pushed a commit to WhitWaldo/dapr-dotnet-sdk that referenced this pull request Oct 25, 2024
Signed-off-by: Rafael Camara <rafaelcamarac@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants