Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of the dotnet-contributing files #1330

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Conversation

Shubhdeep02
Copy link
Contributor

@Shubhdeep02 Shubhdeep02 commented Jul 23, 2024

Description

Improvement of the dotnet-contributing file

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1149

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
@Shubhdeep02 Shubhdeep02 requested review from a team as code owners July 23, 2024 18:25
@philliphoff philliphoff added this to the v1.15 milestone Jul 23, 2024
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@WhitWaldo
Copy link
Contributor

@Shubhdeep02 Would you happen to have any time to review the changes proposed in the next month so we can merge this?

@Shubhdeep02
Copy link
Contributor Author

hey @WhitWaldo sorry for the delay.. was little busy hunting jobs . So should i open a new PR reviewing above changes?

@WhitWaldo
Copy link
Contributor

WhitWaldo commented Oct 7, 2024

hey @WhitWaldo sorry for the delay.. was little busy hunting jobs . So should i open a new PR reviewing above changes?

@Shubhdeep02 Best of luck with your search!

If each of the suggested changes are acceptable to you, GitHub shows a little box that will allow you to sign off and accept the change (bit of a shortcut to doing the same yourself). Once all the reviews are completed, we can complete the merge.

Thank you!

WhitWaldo and others added 7 commits October 8, 2024 11:48
…g.md

Co-authored-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Co-authored-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Co-authored-by: Simon Headley <headleysj@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
…g.md

Co-authored-by: Simon Headley <headleysj@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhitWaldo WhitWaldo merged commit 23e8df0 into dapr:master Oct 16, 2024
10 checks passed
@WhitWaldo
Copy link
Contributor

Thank you very much for your contribution @Shubhdeep02 !

@Shubhdeep02
Copy link
Contributor Author

Really appreciate the help @WhitWaldo....If you don't mind can you please suggest me some open source organizations to which I should approach for their internal software role hiring

@WhitWaldo
Copy link
Contributor

@Shubhdeep02 I'm sorry - I frankly have no real contacts in the open source world that I could refer you to. I do wish you the best in your job search endeavor and hope you're able to find a role soon!

humandigital-michiel pushed a commit to humandigital-agency/dapr-dotnet-sdk that referenced this pull request Oct 23, 2024
Add link about Dapr bot to contribution documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document That Users Can Self-Assign Issues
5 participants