-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of the dotnet-contributing files #1330
Conversation
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
daprdocs/content/en/dotnet-sdk-contributing/dotnet-contributing.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/dotnet-sdk-contributing/dotnet-contributing.md
Outdated
Show resolved
Hide resolved
@Shubhdeep02 Would you happen to have any time to review the changes proposed in the next month so we can merge this? |
hey @WhitWaldo sorry for the delay.. was little busy hunting jobs . So should i open a new PR reviewing above changes? |
@Shubhdeep02 Best of luck with your search! If each of the suggested changes are acceptable to you, GitHub shows a little box that will allow you to sign off and accept the change (bit of a shortcut to doing the same yourself). Once all the reviews are completed, we can complete the merge. Thank you! |
…g.md Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Co-authored-by: Mike Nguyen <hey@mike.ee> Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
Co-authored-by: Simon Headley <headleysj@gmail.com> Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
…g.md Co-authored-by: Simon Headley <headleysj@gmail.com> Signed-off-by: Shubhdeep Singh <shubhdeepsingh1502@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for your contribution @Shubhdeep02 ! |
Really appreciate the help @WhitWaldo....If you don't mind can you please suggest me some open source organizations to which I should approach for their internal software role hiring |
@Shubhdeep02 I'm sorry - I frankly have no real contacts in the open source world that I could refer you to. I do wish you the best in your job search endeavor and hope you're able to find a role soon! |
Add link about Dapr bot to contribution documentation
Description
Improvement of the dotnet-contributing file
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1149
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: