Added unit test to Secrets API test suite #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
KrylixZA
reviewed
Sep 19, 2024
KrylixZA
reviewed
Sep 19, 2024
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…aldo/dapr-dotnet-sdk into additional-secrets-testing
|
@philliphoff or @halspang When you have a moment, would you please give this a quick once-over so we can merge it? No impact on the client - just adding a unit test to validate coverage for a concern raised on Discord. |
philliphoff
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added a simple unit test to the Secrets API test suite to validate that a secret that contains forward slashes in it would have the secret name properly realized through and through (e.g. that it wouldn't limit to any single part of the path).
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: Not a filed issue so much as a concern raised on Discord.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: