Extracted Protos out to common project #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
philliphoff
approved these changes
Oct 16, 2024
humandigital-michiel
pushed a commit
to humandigital-agency/dapr-dotnet-sdk
that referenced
this pull request
Oct 23, 2024
Protos pulled out to separate shared project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the .NET client continues to be expanded out to multiple block-specific clients instead of a monolithic client, each of these other projects will need to maintain their own Protos for interfacing with the runtime. Rather than maintain a collection of different protos in each of those projects, this is a step in preparing for that by extracting the protos out to one shared project.
Future proto updates need only be made against this project for all other Dapr .NET SDK clients to make use of them, simplifying ongoing maintenance.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: