Updating actor serialization documentation #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialization between either type and added a brief section to detail the use of System.Text.Json for weakly-typed Dapr actor clients and to point to official documentation on it Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…verrides Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…r a custom JSON serializer and extension method to facilitate custom enum values during (de)serialization. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
WhitWaldo
added
documentation
philliphoff
approved these changes
Oct 18, 2024
humandigital-michiel
pushed a commit
to humandigital-agency/dapr-dotnet-sdk
that referenced
this pull request
Oct 23, 2024
* Changed headers, updated introduction to reflect the difference in serialization between either type and added a brief section to detail the use of System.Text.Json for weakly-typed Dapr actor clients and to point to official documentation on it --------- Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the actor serialization documentation to reflect the differences between the JSON serialization and the Data Contract serialization approaches used in the Dapr.Actors SDK, how they relate to the different actor client types and some examples of how to properly use each of them.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
This addresses a comment left at #1073 (comment) and occasionally seen in Discord though doesn't have an open issue that I see.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: