Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Removed Serilog nuget from Directory.Packages.props #1376

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

m3nax
Copy link
Contributor

@m3nax m3nax commented Oct 22, 2024

Description

Removed Serilog nuget from DirectoryPackages.props because it can be handled as a transient dependency so you don't have to update it manually.

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@m3nax m3nax requested review from a team as code owners October 22, 2024 08:23
Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com>
@m3nax m3nax changed the title cleanup Removed Serilog nuget from Directory.Packages.props cleanup: Removed Serilog nuget from Directory.Packages.props Oct 22, 2024
Copy link
Contributor

@WhitWaldo WhitWaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @m3nax - looks good to me!

@WhitWaldo WhitWaldo merged commit 5f21620 into dapr:master Oct 22, 2024
10 checks passed
@WhitWaldo WhitWaldo added area/test dependencies Pull requests that update a dependency file labels Oct 22, 2024
@m3nax m3nax deleted the removed-Serilog-nuget branch October 22, 2024 09:39
humandigital-michiel pushed a commit to humandigital-agency/dapr-dotnet-sdk that referenced this pull request Oct 23, 2024
* Removed Serilog nuget from Directory.Packages.props

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>

* Update Directory.Packages.props

Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com>

---------

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
Signed-off-by: Manuel Menegazzo <65919883+m3nax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants